-
Notifications
You must be signed in to change notification settings - Fork 0
Test #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juxnn
wants to merge
3
commits into
main
Choose a base branch
from
test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heozeop
reviewed
Jun 25, 2023
| public class MemberDetailsReqeustDto { | ||
| private String nickname; | ||
| private String email; | ||
| } No newline at end of file |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
마지막 라인 갱신 필요합니당
heozeop
reviewed
Jun 25, 2023
Comment on lines
+10
to
+27
| /* 400 BAD_REQUEST : 잘못된 요청 */ | ||
| ILLEGAL_INPUT_VALUE(HttpStatus.BAD_REQUEST,"규칙에 어긋난 입력값입니다."), | ||
| DUPLICATE_ID_EXIST(HttpStatus.BAD_REQUEST,"이미 존재하는 아이디입니다"), | ||
| PASSWORD_MISMATCH(HttpStatus.BAD_REQUEST,"비밀번호가 일치하지 않습니다."), | ||
| /* 401 UNAUTHORIZED : 인증되지 않은 사용자 */ | ||
| INVALID_AUTH_TOKEN(HttpStatus.UNAUTHORIZED, "권한 정보가 없는 토큰입니다."), | ||
|
|
||
| INVALID_AUTH_TASK(HttpStatus.NOT_ACCEPTABLE, "로그인 시 사용가능한 기능입니다."), | ||
|
|
||
| /* 404 NOT_FOUND : Resource를 찾을 수 없음 */ | ||
| USER_NOT_FOUND(HttpStatus.NOT_FOUND, "해당하는 정보의 사용자를 찾을 수 없습니다."), | ||
|
|
||
| /* 409 : CONFLICT : Resource의 현재 상태와 충돌. 보통 중복된 데이터 존재 */ | ||
| DUPLICATE_RESOURCE(HttpStatus.CONFLICT, "데이터가 이미 존재합니다."), | ||
|
|
||
| NOTE_NOT_FOUND(HttpStatus.NOT_FOUND, "해당하는 정보의 게시글을 찾을 수 없습니다."), | ||
|
|
||
| LOCATION_NOT_FOUND(HttpStatus.NOT_FOUND, "위치정보를 찾을 수 없습니다."), |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
되게 좋은 거 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연습