ds #5
Open
ds #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just printing the first N characters of the element's template, print the first and last N/2. See angular#1854
Closes the first half of angular#1806
Resolves the second half of issue angular#1806
…then This change updates the version of WebDriverJS (selenium-webdriver node module) from 2.44 to 2.45.1. See the full changelog at https://github.com/SeleniumHQ/selenium/blob/master/javascript/node/selenium-webdriver/CHANGES.md To enable the update and remove confusion, this removes the `element().then` function unless there is an action result. This function is completely unnecessary, because it would always resolve to itself, but the removal may cause breaking changes. Before: ```js element(by.css('foo')).then(function(el) { return el.getText().then(...); }); ``` After: ```js element(by.css('foo')).getText().then(...); ``` In other words, an ElementFinder is now no longer a promise until an action has been called. Before: ```js var el = element(by.css('foo')); protractor.promise.isPromise(el); // true protractor.promise.isPromise(el.click()); // true ``` After: ```js var el = element(by.css('foo')); protractor.promise.isPromise(el); // false protractor.promise.isPromise(el.click()); // true ``` Also, fixes `filter` and `map` to work with the new WebDriverJS.
Updated the "angularjs homepage" spec name to the "Protractor Demo App" given the context of what each assertion tests.
Added a cdn value for each binary to be overrided by the cli argument `alternate_cdn`.
x /slowcall -> slowcall
Strengthening the plea to include a reproducible test case, now with test app!
…application which has debugging info disabled Currently Angular application which for performance reasons, have debug information turn off cannot be tested. This PR allows users to add the Angular debug logging flag to the Protractor run.
After this change, you can put multiple browser.pause() in the code. Each browser.pause() is like a traditional breakpoint. To detach from the debugger, press ^D (CTRL+D). This will continue code execution until it hits the next browser.pause() or code finishes running. This PR also fixes a number of small formatting issues.
Makes error messages better
Hankduan patch 1
Create gist.vir
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.