Add NDISTest 6.5 ndprot683 fix #22

kostyanf14 · 2026-01-30T10:52:31Z

No description provided.

gemini-code-assist · 2026-01-30T10:52:49Z

Summary of Changes

Hello @kostyanf14, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a crucial fix for a bug in the ndprot683.sys driver present in the latest Windows Hardware Lab Kit versions. By replacing the faulty driver with a stable alternative and automating this process through configuration files, it resolves network test failures and ensures the reliability of HLK testing for Windows 11 24H2/25H2 and Windows Server 2025.

Highlights

NDISTest 6.5 ndprot683.sys Bug Fix: Addresses a critical bug in the ndprot683.sys driver within the latest Hardware Lab Kit (HLK) for Windows 11 24H2/25H2 and Windows Server 2025, which caused 14 network tests to fail due to packet corruption.
Workaround Implementation: Implements a workaround by replacing the buggy ndprot683.sys with a known good version from NDISTest 6.0 of the Windows Server 2022 HLK, bypassing issues with unsigned protocols found in NDISTest 6.5 from the same kit.
Automated Driver Replacement: Introduces new configuration files (hlk11_24h2-config.json, hlk11_25h2-config.json, hlk2025-config.json) that automate the process of copying the correct ndprot683.sys file to the appropriate HLK installation directory using PowerShell.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a workaround for a bugged ndprot683.sys driver in recent HLK versions by providing configuration files to replace it with a known good version. The .gitignore has been updated to include these new configuration files. The README.md provides good context for the issue and the solution. However, the download_url in the configuration files is empty, which needs to be addressed with clear instructions on how the ndprot683.sys file should be sourced by the user, given it cannot be committed due to licensing. Additionally, there are minor wording improvements suggested for the README.md and a small formatting fix in the JSON configuration files.

gemini-code-assist · 2026-01-30T10:54:14Z

NDIS65_ndprot683_fix/hlk11_24h2-config.json

@@ -0,0 +1,11 @@
+{
+    "download_url": "",


The download_url is empty. Given that ndprot683.sys cannot be committed due to licensing, it's crucial to provide clear instructions in the README.md or here on how the user should obtain and place this file for the fix to work correctly. Without this, the configuration is incomplete and the fix is unusable.

gemini-code-assist · 2026-01-30T10:54:14Z

NDIS65_ndprot683_fix/hlk11_25h2-config.json

@@ -0,0 +1,11 @@
+{
+    "download_url": "",


The download_url is empty. Given that ndprot683.sys cannot be committed due to licensing, it's crucial to provide clear instructions in the README.md or here on how the user should obtain and place this file for the fix to work correctly. Without this, the configuration is incomplete and the fix is unusable.

gemini-code-assist · 2026-01-30T10:54:14Z

NDIS65_ndprot683_fix/hlk2025-config.json

@@ -0,0 +1,11 @@
+{
+    "download_url": "",


The download_url is empty. Given that ndprot683.sys cannot be committed due to licensing, it's crucial to provide clear instructions in the README.md or here on how the user should obtain and place this file for the fix to work correctly. Without this, the configuration is incomplete and the fix is unusable.

gemini-code-assist · 2026-01-30T10:54:14Z

NDIS65_ndprot683_fix/README.md

@@ -0,0 +1,7 @@
+The latest HLK for Windows 11 24H2/25H2 and Windows Server 2025 contains a bugged NDISTest 6.5 ndprot683.sys driver.
+As a result, 14 tests failed due to network package corruption detection.


Consider changing "network package corruption detection" to "network packet corruption detection" for more common terminology.

Suggested change

As a result, 14 tests failed due to network package corruption detection.

As a result, 14 tests failed due to network packet corruption detection.

gemini-code-assist · 2026-01-30T10:54:14Z

NDIS65_ndprot683_fix/README.md

+The latest HLK for Windows 11 24H2/25H2 and Windows Server 2025 contains a bugged NDISTest 6.5 ndprot683.sys driver.
+As a result, 14 tests failed due to network package corruption detection.
+
+As a Workaround replace ndprot683.sys with a file from HLK for Windows Server 2022.


This sentence could be clarified to indicate that the replacement is handled by the provided configuration files, rather than implying a manual step for the user.

Suggested change

As a Workaround replace ndprot683.sys with a file from HLK for Windows Server 2022.

As a workaround, the provided configuration files automate the replacement of ndprot683.sys with a file from HLK for Windows Server 2022.

gemini-code-assist · 2026-01-30T10:54:14Z

NDIS65_ndprot683_fix/README.md

+As a result, 14 tests failed due to network package corruption detection.
+
+As a Workaround replace ndprot683.sys with a file from HLK for Windows Server 2022.
+As NDISTest 6.5 from HLK for Windows Server 2022 contains unsigned protocols (also a bug), use ndprot683.sys from NDISTest 6.0 from HLK for Windows Server 2022.


This sentence is a bit convoluted. Rephrasing it could improve clarity.

Suggested change

As NDISTest 6.5 from HLK for Windows Server 2022 contains unsigned protocols (also a bug), use ndprot683.sys from NDISTest 6.0 from HLK for Windows Server 2022.

Since NDISTest 6.5 from HLK for Windows Server 2022 also contains unsigned protocols (another bug), it's recommended to use ndprot683.sys from NDISTest 6.0 from HLK for Windows Server 2022 instead.

gemini-code-assist · 2026-01-30T10:54:14Z

NDIS65_ndprot683_fix/hlk11_24h2-config.json

+        "kit": "after",
+        "driver": "before"
+    }
+ }


There is a trailing space before the closing brace. This is a minor formatting issue.

Suggested change

}

}

gemini-code-assist · 2026-01-30T10:54:14Z

NDIS65_ndprot683_fix/hlk11_25h2-config.json

+        "kit": "after",
+        "driver": "before"
+    }
+ }


There is a trailing space before the closing brace. This is a minor formatting issue.

Suggested change

}

}

gemini-code-assist · 2026-01-30T10:54:14Z

NDIS65_ndprot683_fix/hlk2025-config.json

+        "kit": "after",
+        "driver": "before"
+    }
+ }


There is a trailing space before the closing brace. This is a minor formatting issue.

Suggested change

}

}

Copilot

Pull request overview

This PR adds a workaround for a bugged NDISTest 6.5 ndprot683.sys driver in the latest HLK releases for Windows 11 24H2/25H2 and Windows Server 2025. The bug causes 14 tests to fail due to network packet corruption detection. The fix replaces the bugged driver with a working version from the Windows Server 2022 HLK.

Changes:

Added configuration files for three HLK versions (Windows 11 24H2, 25H2, and Windows Server 2025) to automate driver replacement
Included documentation explaining the issue and workaround
Added .gitignore to prevent committing the binary driver file

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
NDIS65_ndprot683_fix/hlk2025-config.json	Configuration for Windows Server 2025 HLK to replace ndprot683.sys in NDISTest 6.5 protocol directory
NDIS65_ndprot683_fix/hlk11_25h2-config.json	Configuration for Windows 11 25H2 HLK to replace ndprot683.sys in NDISTest 6.5 protocol directory
NDIS65_ndprot683_fix/hlk11_24h2-config.json	Configuration for Windows 11 24H2 HLK to replace ndprot683.sys in NDISTest 6.5 protocol directory
NDIS65_ndprot683_fix/README.md	Documentation explaining the driver bug, workaround approach, and licensing constraints
NDIS65_ndprot683_fix/.gitignore	Ensures only configuration and documentation files are tracked, excluding the binary driver file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-30T10:57:19Z

NDIS65_ndprot683_fix/README.md

@@ -0,0 +1,7 @@
+The latest HLK for Windows 11 24H2/25H2 and Windows Server 2025 contains a bugged NDISTest 6.5 ndprot683.sys driver.
+As a result, 14 tests failed due to network package corruption detection.


Spelling error: "package" should be "packet". In networking contexts, the correct term is "network packet corruption detection", not "network package corruption detection".

Suggested change

As a result, 14 tests failed due to network package corruption detection.

As a result, 14 tests failed due to network packet corruption detection.

Copilot · 2026-01-30T10:57:19Z

NDIS65_ndprot683_fix/README.md

+The latest HLK for Windows 11 24H2/25H2 and Windows Server 2025 contains a bugged NDISTest 6.5 ndprot683.sys driver.
+As a result, 14 tests failed due to network package corruption detection.
+
+As a Workaround replace ndprot683.sys with a file from HLK for Windows Server 2022.


Grammar issue: "Workaround" at the beginning of the sentence should be lowercase "workaround" or the sentence should be rephrased to "As a workaround, replace".

Suggested change

As a Workaround replace ndprot683.sys with a file from HLK for Windows Server 2022.

As a workaround, replace ndprot683.sys with a file from HLK for Windows Server 2022.

NDIS65_ndprot683_fix/README.md

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>

Copilot AI review requested due to automatic review settings January 30, 2026 10:52

Copilot started reviewing on behalf of kostyanf14 January 30, 2026 10:52 View session

gemini-code-assist bot reviewed Jan 30, 2026

View reviewed changes

Copilot AI reviewed Jan 30, 2026

View reviewed changes

Add NDISTest 6.5 ndprot683 fix

b6c4d1d

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>

kostyanf14 force-pushed the NDIS65_ndprot683_fix branch from 5fd8431 to b6c4d1d Compare January 30, 2026 14:25

kostyanf14 requested a review from YanVugenfirer January 30, 2026 14:26

YanVugenfirer approved these changes Feb 1, 2026

View reviewed changes

YanVugenfirer merged commit 43c6a3b into main Feb 1, 2026

		@@ -0,0 +1,7 @@
		The latest HLK for Windows 11 24H2/25H2 and Windows Server 2025 contains a bugged NDISTest 6.5 ndprot683.sys driver.
		As a result, 14 tests failed due to network package corruption detection.

	As a Workaround replace ndprot683.sys with a file from HLK for Windows Server 2022.
	As a workaround, the provided configuration files automate the replacement of ndprot683.sys with a file from HLK for Windows Server 2022.

	As NDISTest 6.5 from HLK for Windows Server 2022 contains unsigned protocols (also a bug), use ndprot683.sys from NDISTest 6.0 from HLK for Windows Server 2022.
	Since NDISTest 6.5 from HLK for Windows Server 2022 also contains unsigned protocols (another bug), it's recommended to use ndprot683.sys from NDISTest 6.0 from HLK for Windows Server 2022 instead.

	As a Workaround replace ndprot683.sys with a file from HLK for Windows Server 2022.
	As a workaround, replace ndprot683.sys with a file from HLK for Windows Server 2022.

Add NDISTest 6.5 ndprot683 fix #22

Add NDISTest 6.5 ndprot683 fix #22

Uh oh!

Conversation

kostyanf14 commented Jan 30, 2026

Uh oh!

gemini-code-assist bot commented Jan 30, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants