Add profiling to brew tests
#21069
Merged
Add profiling to brew tests
#21069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds profiling support to brew tests using test-prof and the same profilers available in brew prof (stackprof, vernier, ruby-prof). It also includes a performance optimization in formula_installer.rb that reduces overhead in test execution by checking for caskroom directory existence before attempting to load casks.
- Adds
--stackprof,--vernier, and--ruby-profswitches to thetestscommand - Integrates
test-profgem for test profiling capabilities - Optimizes
formula_installer.rbto check caskroom path existence before loading casks
Reviewed Changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Library/Homebrew/dev-cmd/tests.rb | Adds three new profiler switches with conflicts declaration, installs prof gem group when profilers are enabled, and sets up environment variables and output filenames for each profiler |
| Library/Homebrew/formula_installer.rb | Adds short-circuit check for caskroom directory existence before attempting to load cask, improving performance |
| Library/Homebrew/Gemfile | Adds test-prof gem to both style and tests groups |
| Library/Homebrew/Gemfile.lock | Updates lockfile with test-prof 1.4.4 dependency |
| Library/Homebrew/test/spec_helper.rb | Requires test-prof library for test profiling support |
| Library/Homebrew/sorbet/rbi/dsl/homebrew/dev_cmd/tests.rbi | Adds type signatures for new profiler option methods |
| Library/Homebrew/vendor/bundle/bundler/setup.rb | Adds test-prof gem to bundle load path |
| .gitignore | Ignores test profiling output directory and vendored test-prof gem files |
Files not reviewed (1)
- Library/Homebrew/sorbet/rbi/dsl/homebrew/dev_cmd/tests.rbi: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add the same profilers support as `brew prof` using `test-prof`. While we're here, fix a `formula_installer` performance issue that added ~0.5s to every call to `FormulaInstaller#finish` which is a lot of integration tests (already our slowest types).
MikeMcQuaid
force-pushed
the
faster_tests
branch
from
6b10f83 to
956ccbb
Compare
p-linnane
approved these changes
Nov 14, 2025
Member
p-linnane
left a comment
p-linnane
left a comment
There was a problem hiding this comment.
Massive improvement! Thanks!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the same profilers support as
brew profusingtest-prof.While we're here, fix a
formula_installerperformance issue that added ~0.5s to every call toFormulaInstaller#finishwhich is a lot of integration tests (already our slowest types).