dev-cmd/vendor-gems: restore setting up gem environment #21121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to run `Homebrew.install_bundler!` which would run `Homebrew.setup_gem_environment!` and modify the environment variables. Restore this behavior to find `bundler`
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores the Homebrew.setup_gem_environment! call in the vendor-gems dev command that was inadvertently removed. This setup is essential for the command to function correctly, as it configures environment variables (GEM_HOME, GEM_PATH, and PATH) needed to locate and execute the bundle executable.
Key Changes
- Adds
Homebrew.setup_gem_environment!call at the beginning of therunmethod inVendorGemscommand
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
approved these changes
Nov 21, 2025
Member
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Worth a try, thanks @cho-m!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?This used to run
Homebrew.install_bundler!which would runHomebrew.setup_gem_environment!and modify the environment variables. Restore this behavior to findbundler