Skip to content

Conversation

@ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Feb 5, 2025

No description provided.

@ccutrer
Copy link
Contributor Author

ccutrer commented Feb 5, 2025

This will fix openhab/openhab-addons#18219

@ccutrer
Copy link
Contributor Author

ccutrer commented Mar 11, 2025

Ping @jasmith-hs

@jasmith-hs
Copy link
Contributor

@ccutrer , what's the reason for not using getOrDefault? Like {{ value_json['update'].getOrDefault('progress', 'null') }}

@ccutrer
Copy link
Contributor Author

ccutrer commented Mar 11, 2025

Cause I don't control the Jinja. It's from 3rd party software (zigbee2mqtt), that my software (openHAB) has to work with. And that 3rd party software is primary designed to work with other software (Home Assistant) that is written in Python, and thus they have very little incentive to restrict their usage of Jinja to what is compatible with Jinjava. It's open system too... while zigbee2mqtt is a common piece of software that many users integrate with, there's no limitations - there are hundreds of devices that use the same specification, but I couldn't possibly hope to specifically test with.

Copy link
Contributor

@jasmith-hs jasmith-hs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cause I don't control the Jinja. It's from 3rd party software (zigbee2mqtt), that my software (openHAB) has to work with. And that 3rd party software is primary designed to work with other software (Home Assistant) that is written in Python, and thus they have very little incentive to restrict their usage of Jinja to what is compatible with Jinjava. It's open system too... while zigbee2mqtt is a common piece of software that many users integrate with, there's no limitations - there are hundreds of devices that use the same specification, but I couldn't possibly hope to specifically test with.

Oh mb, I didn't realise that was the jinja functionality.

Co-authored-by: Jack Smith <72623970+jasmith-hs@users.noreply.github.com>
@jasmith-hs jasmith-hs merged commit ab82426 into HubSpot:master Mar 14, 2025
2 checks passed
@ccutrer ccutrer deleted the py-map-get-with-default branch April 11, 2025 20:15
@ccutrer
Copy link
Contributor Author

ccutrer commented Apr 11, 2025

@jasmith-hs: Any estimate on when the next release will be made?

@jasmith-hs
Copy link
Contributor

I will work on releasing Jinjava 2.8.0 soon; hopefully this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants