-
Notifications
You must be signed in to change notification settings - Fork 172
Implement PyMap.get with the optional default. #1233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This will fix openhab/openhab-addons#18219 |
|
Ping @jasmith-hs |
|
@ccutrer , what's the reason for not using |
|
Cause I don't control the Jinja. It's from 3rd party software (zigbee2mqtt), that my software (openHAB) has to work with. And that 3rd party software is primary designed to work with other software (Home Assistant) that is written in Python, and thus they have very little incentive to restrict their usage of Jinja to what is compatible with Jinjava. It's open system too... while zigbee2mqtt is a common piece of software that many users integrate with, there's no limitations - there are hundreds of devices that use the same specification, but I couldn't possibly hope to specifically test with. |
jasmith-hs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cause I don't control the Jinja. It's from 3rd party software (zigbee2mqtt), that my software (openHAB) has to work with. And that 3rd party software is primary designed to work with other software (Home Assistant) that is written in Python, and thus they have very little incentive to restrict their usage of Jinja to what is compatible with Jinjava. It's open system too... while zigbee2mqtt is a common piece of software that many users integrate with, there's no limitations - there are hundreds of devices that use the same specification, but I couldn't possibly hope to specifically test with.
Oh mb, I didn't realise that was the jinja functionality.
src/main/java/com/hubspot/jinjava/objects/collections/PyMap.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jack Smith <72623970+jasmith-hs@users.noreply.github.com>
|
@jasmith-hs: Any estimate on when the next release will be made? |
|
I will work on releasing Jinjava 2.8.0 soon; hopefully this week |
No description provided.