fix(eager execution): Create DeferredNodes rather than NotInLoopException when trying to evaluate continue or break in a deferred for loop #1265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't implemented handling of
{% break %}or{% continue %}in eager execution fully so they must create deferred nodes rather than deferred tokens when used in deferred for loops or deferred if statements within for loops.The latter was handled, but the former was not handled correctly as we'd end up throwing a
NotInLoopExceptionrather than aDeferredValueException: