Interpret additional variables from HRRR grids #126
Conversation
Interpret additional variables from HRRR grids. Use "wind" in variable name to correctly interpret wind speed grids. Resolves: HMS-4620
tombrauer
left a comment
tombrauer
left a comment
There was a problem hiding this comment.
@albreverman I left a few review comments. Let me know if you have any questions.
| GEFS("ge.*\\.pgrb2.*\\.0p.*\\.f.*\\..*", ".*"), | ||
| LIVNEH_PRECIP("prec.\\d{4}.nc", ".*"), | ||
| HRRR_WRFSFCF("hrrr.*wrfsfcf.*", ".*"), | ||
| HRRR_APCP("hrrr.*", ".*APCP.*"), // Precipitation |
There was a problem hiding this comment.
Every regex added to this list dramatically increases processing times for large datasets. Because of the performance implications, one of my goals is to stop adding variables to this list and to use this approach instead. If you really do think HRRR should be added to this list (which I would understand given it's relevance) can you try to consolidate to just one regex instead of many? That will be less impactful on performance.
| return DssDataType.PER_CUM; | ||
| if (variable == TEMPERATURE) | ||
| return DssDataType.INST_VAL; | ||
| if (variable == HUMIDITY) |
There was a problem hiding this comment.
From this table in the user's manual it looks like humidity, radiation, pressure, temperature, and windspeed can be instantaneous or period data. I would try re-writing this method to accommodate those cases. You'll see some of the other variables like SWE have a second conditional for interval.
Interpret additional variables from HRRR grids. Use "wind" in variable name to correctly interpret wind speed grids.
Resolves: HMS-4620