Skip to content

Conversation

@Baptouuuu
Copy link
Member

At first it was there to mimic psr messages. But when used with innmind/http-server or innmind/framework it feels awkward to have env variables accessible on the request as it doesn't change between 2 requests.

Also env variables should be used to initialize an app and not used afterward.

So to push toward a better usage, env variables will be provided by innmind/http-server.

@Baptouuuu Baptouuuu self-assigned this Feb 1, 2026
@codecov
Copy link

codecov bot commented Feb 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.05%. Comparing base (be66a37) to head (bc7b33f).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #23      +/-   ##
=============================================
- Coverage      94.07%   94.05%   -0.03%     
+ Complexity      1096     1075      -21     
=============================================
  Files            197      192       -5     
  Lines           4323     4236      -87     
=============================================
- Hits            4067     3984      -83     
+ Misses           256      252       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Baptouuuu Baptouuuu merged commit ad1eb4c into develop Feb 1, 2026
38 of 40 checks passed
@Baptouuuu Baptouuuu deleted the remove-environment branch February 1, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants