Add NoDiscard attributes on mutation free methods

psalm.xml

@@ -14,4 +14,7 @@
             <directory name="vendor" />
         </ignoreFiles>
     </projectFiles>
+    <issueHandlers>
+        <UndefinedAttributeClass errorLevel="suppress" />
+    </issueHandlers>
 </psalm>

src/ClientError.php

@@ -8,6 +8,9 @@
     Response,
 };
 
+/**
+ * @psalm-immutable
+ */
 final class ClientError
 {
     private Request $request;
@@ -23,11 +26,13 @@ public function __construct(Request $request, Response $response)
         $this->response = $response;
     }
 
+    #[\NoDiscard]
     public function request(): Request
     {
         return $this->request;
     }
 
+    #[\NoDiscard]
     public function response(): Response
     {
         return $this->response;

src/ConnectionFailed.php

@@ -5,6 +5,9 @@
 
 use Innmind\Http\Request;
 
+/**
+ * @psalm-immutable
+ */
 final class ConnectionFailed
 {
     public function __construct(
@@ -13,11 +16,13 @@ public function __construct(
     ) {
     }
 
+    #[\NoDiscard]
     public function request(): Request
     {
         return $this->request;
     }
 
+    #[\NoDiscard]
     public function reason(): string
     {
         return $this->reason;

src/Curl.php

@@ -79,6 +79,7 @@ public static function of(
      *
      * @param positive-int $max
      */
+    #[\NoDiscard]
     public function maxConcurrency(int $max): self
     {
         return new self(
@@ -98,6 +99,7 @@ public function maxConcurrency(int $max): self
      * @param Period $timeout Only seconds are allowed
      * @param callable(): void $heartbeat
      */
+    #[\NoDiscard]
     public function heartbeat(Period $timeout, ?callable $heartbeat = null): self
     {
         return new self(
@@ -120,6 +122,7 @@ public function heartbeat(Period $timeout, ?callable $heartbeat = null): self
      *
      * @psalm-mutation-free
      */
+    #[\NoDiscard]
     public function disableSSLVerification(): self
     {
         return new self(
@@ -136,6 +139,7 @@ public function disableSSLVerification(): self
     /**
      * @psalm-mutation-free
      */
+    #[\NoDiscard]
     public function proxy(Url $proxy): self
     {
         return new self(

src/Failure.php

@@ -5,6 +5,9 @@
 
 use Innmind\Http\Request;
 
+/**
+ * @psalm-immutable
+ */
 final class Failure
 {
     public function __construct(
@@ -13,11 +16,13 @@ public function __construct(
     ) {
     }
 
+    #[\NoDiscard]
     public function request(): Request
     {
         return $this->request;
     }
 
+    #[\NoDiscard]
     public function reason(): string
     {
         return $this->reason;

src/Information.php

@@ -8,6 +8,9 @@
     Response,
 };
 
+/**
+ * @psalm-immutable
+ */
 final class Information
 {
     private Request $request;
@@ -23,11 +26,13 @@ public function __construct(Request $request, Response $response)
         $this->response = $response;
     }
 
+    #[\NoDiscard]
     public function request(): Request
     {
         return $this->request;
     }
 
+    #[\NoDiscard]
     public function response(): Response
     {
         return $this->response;

src/MalformedResponse.php

@@ -6,6 +6,9 @@
 use Innmind\HttpTransport\MalformedResponse\Raw;
 use Innmind\Http\Request;
 
+/**
+ * @psalm-immutable
+ */
 final class MalformedResponse
 {
     private Request $request;
@@ -17,11 +20,13 @@ public function __construct(Request $request, ?Raw $raw = null)
         $this->raw = $raw ?? Raw::none();
     }
 
+    #[\NoDiscard]
     public function request(): Request
     {
         return $this->request;
     }
 
+    #[\NoDiscard]
     public function raw(): Raw
     {
         return $this->raw;

src/MalformedResponse/Raw.php

@@ -42,6 +42,7 @@ public static function none(): self
         return new self(Str::of(''), Sequence::of(), Content::none());
     }
 
+    #[\NoDiscard]
     public function statusLine(): Str
     {
         return $this->statusLine;
@@ -50,11 +51,13 @@ public function statusLine(): Str
     /**
      * @return Sequence<Str>
      */
+    #[\NoDiscard]
     public function headers(): Sequence
     {
         return $this->headers;
     }
 
+    #[\NoDiscard]
     public function body(): Content
     {
         return $this->body;

src/Redirection.php

@@ -8,6 +8,9 @@
     Response,
 };
 
+/**
+ * @psalm-immutable
+ */
 final class Redirection
 {
     private Request $request;
@@ -23,11 +26,13 @@ public function __construct(Request $request, Response $response)
         $this->response = $response;
     }
 
+    #[\NoDiscard]
     public function request(): Request
     {
         return $this->request;
     }
 
+    #[\NoDiscard]
     public function response(): Response
     {
         return $this->response;

src/ServerError.php

@@ -8,6 +8,9 @@
     Response,
 };
 
+/**
+ * @psalm-immutable
+ */
 final class ServerError
 {
     private Request $request;
@@ -23,11 +26,13 @@ public function __construct(Request $request, Response $response)
         $this->response = $response;
     }
 
+    #[\NoDiscard]
     public function request(): Request
     {
         return $this->request;
     }
 
+    #[\NoDiscard]
     public function response(): Response
     {
         return $this->response;

src/Success.php

@@ -8,6 +8,9 @@
     Response,
 };
 
+/**
+ * @psalm-immutable
+ */
 final class Success
 {
     private Request $request;
@@ -23,11 +26,13 @@ public function __construct(Request $request, Response $response)
         $this->response = $response;
     }
 
+    #[\NoDiscard]
     public function request(): Request
     {
         return $this->request;
     }
 
+    #[\NoDiscard]
     public function response(): Response
     {
         return $this->response;

src/Transport.php

@@ -14,5 +14,6 @@ interface Transport
     /**
      * @return Either<Errors, Success>
      */
+    #[\NoDiscard]
     public function __invoke(Request $request): Either;
 }