Skip to content

Conversation

@wadoon
Copy link
Member

@wadoon wadoon commented Apr 6, 2025

This PR brings a tool for rewriting the settings in KeY files to the new JSON-like format. A requirement to get rid of the old property-based interface.

Changes along the road:

  • The KeYLexer can be configured whether \proof is also treated as EOF or not. In normal mode, the lexer stops at \proof so that the s-expr of the proof are not going through the parser.

Plan

Type of pull request

  • Refactoring (behaviour should not change or only minimally change)
    • Lexer became the possibility to not stop at \proof.

Ensuring quality

  • Before overwriting the file, the reformatter checks the parseability.
    The rewriting itself is done via the settings classes (load/store methods), as we are not morons, this should ensure settings equality.

@wadoon wadoon requested a review from mattulbrich April 6, 2025 18:39
@wadoon wadoon self-assigned this Apr 6, 2025
@wadoon wadoon added the 🛠 Maintenance Code quality and related things w/o functional changes label Apr 6, 2025
@wadoon wadoon force-pushed the weigl/settingsrewriter branch 2 times, most recently from 4ecc7ac to 0e7e297 Compare April 17, 2025 13:11
@mattulbrich
Copy link
Member

Agreed during meeting: Move to scripts directory. Reminder: When removing from the parser, make sure to give a descriptive error message.

@wadoon wadoon force-pushed the weigl/settingsrewriter branch from 0e7e297 to 5a0ef3e Compare May 27, 2025 21:28
@wadoon wadoon force-pushed the weigl/settingsrewriter branch from 5a0ef3e to 812cd8d Compare June 6, 2025 22:40
@wadoon wadoon marked this pull request as draft June 6, 2025 22:41
@wadoon wadoon force-pushed the weigl/settingsrewriter branch 2 times, most recently from bd87b0f to 6aed5af Compare June 14, 2025 09:51
@wadoon wadoon force-pushed the weigl/settingsrewriter branch from 6aed5af to 68426b5 Compare June 29, 2025 22:46
@wadoon wadoon force-pushed the weigl/settingsrewriter branch from 68426b5 to bd44701 Compare September 7, 2025 22:40
@wadoon wadoon added this to the v2.12.4 milestone Sep 7, 2025
@wadoon wadoon force-pushed the weigl/settingsrewriter branch from bd44701 to 0744c12 Compare November 20, 2025 15:14
@wadoon wadoon force-pushed the weigl/settingsrewriter branch from 0744c12 to e15c746 Compare November 22, 2025 14:58
wadoon added a commit that referenced this pull request Nov 22, 2025
wadoon added a commit that referenced this pull request Dec 7, 2025
wadoon added a commit that referenced this pull request Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🛠 Maintenance Code quality and related things w/o functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants