Skip to content

Conversation

@nishasy
Copy link
Contributor

@nishasy nishasy commented Dec 9, 2025

Summary:

Create a generator for the Radio widget to make testdata easier to read and write.

NOTE: There is already a radio buidler, but it's not as versatile as the generator.
I will be replacing all the usages of the builder with the generator + removing the builder
in an upcoming PR.

Issue: https://khanacademy.atlassian.net/browse/LEMS-3771

Test plan:

pnpm jest

@nishasy nishasy self-assigned this Dec 9, 2025
@nishasy nishasy requested a review from a team December 9, 2025 01:47
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

🗄️ Schema Change: No Changes ✅

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Size Change: +29 B (+0.01%)

Total Size: 499 kB

Filename Size Change
packages/perseus-core/dist/es/index.js 25.4 kB +45 B (+0.18%)
packages/perseus/dist/es/index.js 200 kB -16 B (-0.01%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 20.8 kB
packages/keypad-context/dist/es/index.js 1 kB
packages/kmath/dist/es/index.js 5.98 kB
packages/math-input/dist/es/index.js 99.2 kB
packages/math-input/dist/es/strings.js 1.61 kB
packages/perseus-core/dist/es/index.item-splitting.js 13.1 kB
packages/perseus-editor/dist/es/index.js 97.7 kB
packages/perseus-linter/dist/es/index.js 8.64 kB
packages/perseus-score/dist/es/index.js 9.2 kB
packages/perseus-utils/dist/es/index.js 403 B
packages/perseus/dist/es/strings.js 7.73 kB
packages/pure-markdown/dist/es/index.js 1.39 kB
packages/simple-markdown/dist/es/index.js 6.72 kB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

🛠️ Item Splitting: No Changes ✅

@nishasy nishasy marked this pull request as ready for review December 9, 2025 01:49
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (a7ecd10) and published it to npm. You
can install it using the tag PR3106.

Example:

pnpm add @khanacademy/perseus@PR3106

If you are working in Khan Academy's frontend, you can run the below command.

./dev/tools/bump_perseus_version.ts -t PR3106

If you are working in Khan Academy's webapp, you can run the below command.

./dev/tools/bump_perseus_version.js -t PR3106

Copy link
Contributor

@mark-fitzgerald mark-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nishasy nishasy changed the base branch from definition-generator to main December 9, 2025 22:10
An error occurred while trying to automatically change base from definition-generator to main December 9, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants