Skip to content

Conversation

@jandrade
Copy link
Member

Summary:

A new take on the floating-ui experiment.

  • Add Floating package (experiment)
  • Switches to WB Floating instead of PopperJS.

Issue: WB-2112

Test plan:

TBD

@jandrade jandrade self-assigned this Oct 22, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2025

🦋 Changeset detected

Latest commit: d0a4571

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@khanacademy/wonder-blocks-dropdown Patch
@khanacademy/wonder-blocks-floating Minor
@khanacademy/wonder-blocks-tooltip Major
@khanacademy/wonder-blocks-popover Major
@khanacademy/wonder-blocks-modal Major
@khanacademy/wonder-blocks-birthday-picker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team October 22, 2025 18:16
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Oct 22, 2025

Gerald

Required Reviewers
  • @Khan/wonder-blocks for changes to package.json, pnpm-lock.yaml, pnpm-workspace.yaml, tsconfig-build.json, .changeset/breezy-penguins-bathe.md, .changeset/dull-dingos-design.md, .changeset/honest-monkeys-move.md, .changeset/rotten-ants-carry.md, .changeset/wicked-squids-joke.md, __docs__/wonder-blocks-floating/floating.argtypes.ts, __docs__/wonder-blocks-floating/floating.stories.tsx, __docs__/wonder-blocks-popover/popover.stories.tsx, packages/wonder-blocks-dropdown/package.json, packages/wonder-blocks-dropdown/tsconfig-build.json, packages/wonder-blocks-floating/package.json, packages/wonder-blocks-floating/tsconfig-build.json, packages/wonder-blocks-popover/package.json, packages/wonder-blocks-popover/tsconfig-build.json, packages/wonder-blocks-tooltip/package.json, packages/wonder-blocks-tooltip/tsconfig-build.json, packages/wonder-blocks-floating/src/index.ts, packages/wonder-blocks-modal/src/index.ts, packages/wonder-blocks-tooltip/src/index.ts, packages/wonder-blocks-dropdown/src/components/dropdown-popper.tsx, packages/wonder-blocks-floating/src/components/floating.tsx, packages/wonder-blocks-floating/src/util/constants.ts, packages/wonder-blocks-floating/src/util/maybe-get-portal-mounted-modal-host-element.test.tsx, packages/wonder-blocks-floating/src/util/maybe-get-portal-mounted-modal-host-element.ts, packages/wonder-blocks-popover/src/components/popover-anchor.ts, packages/wonder-blocks-popover/src/components/popover-content-core.tsx, packages/wonder-blocks-popover/src/components/popover-dialog.tsx, packages/wonder-blocks-popover/src/components/popover.tsx, packages/wonder-blocks-tooltip/src/components/tooltip-anchor.tsx, packages/wonder-blocks-tooltip/src/components/tooltip-bubble.tsx, packages/wonder-blocks-tooltip/src/components/tooltip.tsx, packages/wonder-blocks-popover/src/components/__tests__/popover-anchor.test.tsx, packages/wonder-blocks-popover/src/components/__tests__/popover-dialog.test.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

Size Change: -3.83 kB (-3.52%)

Total Size: 105 kB

Filename Size Change
packages/wonder-blocks-modal/dist/es/index.js 6.99 kB -109 B (-1.54%)
packages/wonder-blocks-popover/dist/es/index.js 3.03 kB -1.27 kB (-29.54%) 🎉
packages/wonder-blocks-tooltip/dist/es/index.js 2.7 kB -3.69 kB (-57.72%) 🏆
packages/wonder-blocks-floating/dist/es/index.js 1.25 kB +1.25 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
packages/wonder-blocks-accordion/dist/es/index.js 3 kB
packages/wonder-blocks-announcer/dist/es/index.js 1.74 kB
packages/wonder-blocks-badge/dist/es/index.js 1.91 kB
packages/wonder-blocks-banner/dist/es/index.js 2.01 kB
packages/wonder-blocks-birthday-picker/dist/es/index.js 1.92 kB
packages/wonder-blocks-breadcrumbs/dist/es/index.js 755 B
packages/wonder-blocks-button/dist/es/index.js 4.25 kB
packages/wonder-blocks-card/dist/es/index.js 1.01 kB
packages/wonder-blocks-cell/dist/es/index.js 2.19 kB
packages/wonder-blocks-clickable/dist/es/index.js 2.66 kB
packages/wonder-blocks-core/dist/es/index.js 2.48 kB
packages/wonder-blocks-data/dist/es/index.js 5.48 kB
packages/wonder-blocks-dropdown/dist/es/index.js 19.4 kB
packages/wonder-blocks-form/dist/es/index.js 6.2 kB
packages/wonder-blocks-grid/dist/es/index.js 1.24 kB
packages/wonder-blocks-icon-button/dist/es/index.js 3.16 kB
packages/wonder-blocks-icon/dist/es/index.js 1.91 kB
packages/wonder-blocks-labeled-field/dist/es/index.js 3.48 kB
packages/wonder-blocks-layout/dist/es/index.js 1.63 kB
packages/wonder-blocks-link/dist/es/index.js 1.52 kB
packages/wonder-blocks-pill/dist/es/index.js 1.31 kB
packages/wonder-blocks-progress-spinner/dist/es/index.js 1.48 kB
packages/wonder-blocks-search-field/dist/es/index.js 1.1 kB
packages/wonder-blocks-styles/dist/es/index.js 464 B
packages/wonder-blocks-switch/dist/es/index.js 1.55 kB
packages/wonder-blocks-tabs/dist/es/index.js 3.71 kB
packages/wonder-blocks-testing-core/dist/es/index.js 3.25 kB
packages/wonder-blocks-testing/dist/es/index.js 978 B
packages/wonder-blocks-theming/dist/es/index.js 384 B
packages/wonder-blocks-timing/dist/es/index.js 1.37 kB
packages/wonder-blocks-tokens/dist/es/index.js 4.99 kB
packages/wonder-blocks-toolbar/dist/es/index.js 906 B
packages/wonder-blocks-typography/dist/es/index.js 1.57 kB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

A new build was pushed to Chromatic! 🚀

https://5e1bf4b385e3fb0020b7073c-tltupxmfld.chromatic.com/

Chromatic results:

Metric Total
Captured snapshots 0
Tests with visual changes 14
Total stories 733
Inherited (not captured) snapshots [TurboSnap] 442
Tests on the build 442

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (3bf1ae6) and published all packages with changesets to npm.

You can install the packages in frontend by running:

./dev/tools/deploy_wonder_blocks.js --tag="PR2826"

Packages can also be installed manually by running:

pnpm add @khanacademy/wonder-blocks-<package-name>@PR2826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants