[WB-2119.0] Popover: Re-enable Popover snapshots for Chromatic #2894
Conversation
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (dc7a11c) and published all packages with changesets to npm. You can install the packages in ./dev/tools/deploy_wonder_blocks.js --tag="PR2894"Packages can also be installed manually by running: pnpm add @khanacademy/wonder-blocks-<package-name>@PR2894 |
|
Size Change: 0 B Total Size: 109 kB ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-rfaxdagtcn.chromatic.com/ Chromatic results:
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
beaesguerra
left a comment
beaesguerra
left a comment
There was a problem hiding this comment.
Looks good to me! Left a non-blocking suggestion for one of the snapshots :)
| export const InCorners = (args: PropsFor<typeof Popover>) => { | ||
| const [openedIndex, setOpenedIndex] = React.useState<number>(0); | ||
| const renderPopover = (index: number) => { | ||
| export const InCorners: StoryComponentType = { |
There was a problem hiding this comment.
I left a comment in the snapshot asking if we should open all the Popovers for the snapshot so that we can make sure the viewport padding is all around it (I can't remember why I added this story and made it open one at a time!)
Summary:
The Popover component is not currently being tested in Chromatic. This PR
re-enables the snapshots for this component so we can ensure that we don't break
the component in the upcoming Floating UI migration.
Issue: https://khanacademy.atlassian.net/browse/WB-2119
Test plan:
Verify that the snapshots are re-introduced for the Popover component.