Blocks: Add Margin and Padding Support #844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n7studios
commented
Jul 7, 2025
| // See: https://github.com/WordPress/gutenberg/issues/32417. | ||
| '__experimentalSkipSerialization' => true, | ||
| ), | ||
| 'typography' => array( |
Contributor
Author
There was a problem hiding this comment.
This was never supported in the Product block, so not sure when this got added. I'd prefer to add typography / font selection support in a separate PR that covers all blocks, so we have consistent options for users.
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
This ensures the preview matches the output of the page
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
6 tasks
n7studios
requested review from
a team,
corydhmiller and
noelherrick
and removed request for
a team
noelherrick
approved these changes
Jul 8, 2025
`visualizers` aren’t needed in the block editor. `fontSize` belongs within `typography`
6 tasks
Blocks: Add Typography Support
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the block editor's native margin and padding controls to the Broadcasts, Form Trigger and Product blocks.
Testing
testBroadcastsBlockWithMarginAndPaddingParameters: Test the Broadcasts block's margin and padding parameters works.testFormTriggerBlockWithMarginAndPaddingParameters: Test the Form Trigger block's margin and padding parameters works.testProductBlockWithMarginAndPaddingParameters: Test the Product block's margin and padding parameters works.Checklist