Skip to content

Conversation

@OsiJr
Copy link
Member

@OsiJr OsiJr commented Jan 4, 2019

No description provided.

@OsiJr OsiJr added the enhancement New feature or request label Jan 4, 2019
@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #8 into master will increase coverage by 9.83%.
The diff coverage is 88.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage    65.4%   75.24%   +9.83%     
==========================================
  Files          11       13       +2     
  Lines        1113     1208      +95     
==========================================
+ Hits          728      909     +181     
+ Misses        385      299      -86
Impacted Files Coverage Δ
src/lorString.h 96.7% <100%> (+0.65%) ⬆️
src/lorMemory.h 100% <100%> (ø) ⬆️
src/comms/lorHTTP.cpp 85.71% <85.71%> (ø)
src/comms/lorSocket.h 100% <0%> (ø)
src/comms/lorSocket.cpp 43.3% <0%> (+43.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09369af...0cfb026. Read the comment docs.

@OsiJr
Copy link
Member Author

OsiJr commented Jan 5, 2019

Might actually change this to support binary properly, immediately hit the problem where I wanted to send and recv binary data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants