[10주차] ejy #62
Open
[10주차] ejy #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PandaHun
requested changes
May 2, 2021
Member
PandaHun
left a comment
PandaHun
left a comment
There was a problem hiding this comment.
거의 다 된 것 같습니다.
피드백 드린부분 수정해서 재리뷰 요청 부탁드립니다.
| Cars cars = new Cars(inputCarNames()); | ||
| GameCounter gameCounter = inputGameCount(); | ||
| OutputView.printGamePreview(); | ||
| while (gameCounter.nextRound() > FINAL_ROUND) { |
Member
There was a problem hiding this comment.
gameCounter에 메세지를 보내도 구현이 가능 할 것 같네요
| import java.util.stream.IntStream; | ||
|
|
||
| import static view.InputView.inputCarNames; | ||
| import static view.InputView.inputGameCount; |
|
|
||
| public class RandomUtils { | ||
| private static final Random RANDOM = new Random(); | ||
| private static final int ZERO = 0; |
| String input = nextLine(); | ||
| validateCarNames(input); | ||
| return Arrays.asList(input.split(DELIMITER)); | ||
| } |
Member
There was a problem hiding this comment.
어떤 부분에선 도메인으로 어떤 부분에서는 원시타입으로 리턴하는데
해당 부분을 통일 시켜주세요
|
|
||
| public void moveCars() { | ||
| cars.stream() | ||
| .filter(car -> Engine.isPower()) |
| .forEach(Car::go); | ||
| } | ||
|
|
||
| public void printCars() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.