Added multiplayer features to blackjack #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed an issue with the handeling of 'duration' when it started with an alphabetic character. and (hopefully) made the code PEP 8 compliant.
only works in multiplayer blackjack games, and can only be done before the dealer draws their hand. All players must place a bet in order for the dealer to draw their hand.
it now returns (the player and the game they're in) or None refactored code that uses it.
added 30 commits
December 30, 2025 22:42
the idea is solid but needs lots of refactoring which I'm too lazy to do Better to revert it for now until someone (hopefully) refactors how all reports are made.
was monkeypatching in the wrong place lol
also fixed an issue with BlackjackGame.get_player()
it would index out of range if match/round is over
issue was that BlackjackGame.turn_idx is changed in singleplayer. this is technically a hack as BlackjackGame.turn_idx should ideally be changed in both single and multiplayer games.
- appending the help was very wrong.
- when a player perfects a turn would always be skipped
instead of only skipping if it's their turn.
- test_blackjack_multiplayer_start_game_skip_perfected_players() - test_blackjack_multiplayer() - test_deal_current_player() - test_blackjack_multiplayer_dealer_blackjack() also added the helper make_blackjack_multiplayer_with_unique_user_id()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new commands:
tablenew: create a new multiplayer blackjack game.
tablejoin : join target's blackjack game.
tableleave: leave the current blackjack game.
tablebet: make a bet on the next blackjack round.
tablestart: start a blackjack match started with 'tablenew'.
the old '!blackjack' command's functionality has not been changed, you can't join a blackjack game made with 'blackjack'.