Reinstate checkpoint_path_prefix in MLFlowLogger #21432
Open
+69
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reinstates the optional
checkpoint_path_prefixargument for theMLFlowLogger.This was added in
lightning==2.5.1but removed inlightning==2.6.0.Why?
lightning<2.5logged model checkpoints in MLFlow under a hard-coded subfolder:model/checkpointslightning==2.5.0changed this to log checkpoints under the root folder within a run.This location change broke the MLOps tooling of myself and others who programatically retrieved these checkpoints.
The
checkpoint_path_prefixargument added by @benglewis in #20538 meant that the previous behaviour could be restored. It was susceptible to a bug in MLFlow, so a patch in Lightning was introduced in #20669However, both changes were yanked from the master branch:
The root issue was later fixed in MLFlow in mlflow/mlflow#16660 (MLFlow 3.6)
Closes #20932
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21432.org.readthedocs.build/en/21432/