-
Notifications
You must be signed in to change notification settings - Fork 758
Add a current frame iterator for streamed trajectories #5184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add a current frame iterator for streamed trajectories #5184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5184 +/- ##
===========================================
+ Coverage 92.72% 92.74% +0.01%
===========================================
Files 180 180
Lines 22472 22491 +19
Branches 3188 3192 +4
===========================================
+ Hits 20838 20860 +22
+ Misses 1176 1174 -2
+ Partials 458 457 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This seems like a good idea to me - but I would defer to those more experienced with MDA & streaming as for why this approach maybe wasn't already taken. |
|
I’m away from most of work (and open source) and won’t get to reviewing until the new year. But please let this not halt any discussions here! |
* This enables analysis classes to use current frame as reference in `__init__`
Fixes #5183
Changes made in this Pull Request:
runmethod as.run(frames=[u.trajectory.frame])u.trajectory[u.trajectory.frame]to get current timestepRMSD,AverageStructure) to use current frame as aref_frame(in their__init__method)This PR allows us to do something like the following:
Here is a sample output of the per-frame analysis above:
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--5184.org.readthedocs.build/en/5184/