Aligned command with tailscale login flow #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
[ci skip]
aryanjassal
changed the title
shafiqihtsham
suggested changes
Jun 26, 2025
Contributor
shafiqihtsham
left a comment
shafiqihtsham
left a comment
There was a problem hiding this comment.
Looks good. I just left some questions about things I was confused with. Just a bit of nitpicking as well with the command description and what is shown to the user. Otherwise this looks good to merge.
Contributor
Author
|
Everything has been done for this PR and it is all working as intended. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Fixed
polykey auth logincommand #408 (REF ENG-620)Tasks
Final checklist