Fix Disk Drive Labeling #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ILO5 on Gen10 machines produce a different API output with regards to disk location. This had the effect of producing empty and therefore omitted location labels. The flow on of that was that there was no differentiating label between disks of the same model meaning disks were not represented in the metrics. This change adds support for the new location data structure as well as includes the disk Name and serial number for extra differentiation.
ChrisPortman
force-pushed
the
fix-disk-labels
branch
from
32c57d6 to
c909dc9
Compare
czerwonk
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ILO5 on Gen10 machines produce a different API output with regards to disk location. This had the effect of producing empty and therefore omitted location labels. The flow on of that was that there was no differentiating label between disks of the same model meaning disks were not represented in the metrics.
This change adds support for the new location data structure as well as includes the disk Name and serial number for extra differentiation.