Skip to content

set rpath for mdctl native node extensions #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpetrucciani merged 1 commit into from
Jan 22, 2026
Merged

set rpath for mdctl native node extensions #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions mods/pkgs/mdctl-alpha/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@ let
json = fromJSON (readFile ./package.json);
pname = replaceStrings [ "@" "/" ] [ "" "-" ] (head (attrNames json.dependencies));
version = head (attrValues json.dependencies);
keytarRuntimeLibs = lib.optionals stdenv.isLinux [
libsecret
glib
stdenv.cc.cc.lib
zlib
openssl
libffi
pcre2
];
linuxRpath = lib.makeLibraryPath keytarRuntimeLibs;
modules = (yarn2nix.mkYarnModules {
inherit version;
pname = "${pname}-modules";
Expand All @@ -19,6 +29,7 @@ let
] ++ lib.optionals stdenv.isLinux [
libsecret
glib
patchelf
] ++ osSpecific;
};
sqlite3.buildInputs = [ python3 pkg-config ];
Expand All @@ -30,6 +41,19 @@ let
'';
}).overrideAttrs (old: {
NODE_EXTRA_CA_CERTS = "${cacert}/etc/ssl/certs/ca-bundle.crt";
postFixup = (old.postFixup or "") + lib.optionalString pkgs.stdenv.isLinux ''
echo "Patching RPATH for native addons -> ${linuxRpath}"
while IFS= read -r -d "" f; do
if file "$f" | grep -q ELF; then
old_rpath="$(patchelf --print-rpath "$f" 2>/dev/null || true)"
if [ -n "$old_rpath" ]; then
patchelf --set-rpath "${linuxRpath}:$old_rpath" "$f" || true
else
patchelf --set-rpath "${linuxRpath}" "$f" || true
fi
fi
done < <(find "$out/node_modules" -type f -name '*.node' -print0)
'';
});
in
stdenv.mkDerivation {
Expand Down
24 changes: 24 additions & 0 deletions mods/pkgs/mdctl/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@ let
json = fromJSON (readFile ./package.json);
pname = replaceStrings [ "@" "/" ] [ "" "-" ] (head (attrNames json.dependencies));
version = head (attrValues json.dependencies);
keytarRuntimeLibs = lib.optionals stdenv.isLinux [
libsecret
glib
stdenv.cc.cc.lib
zlib
openssl
libffi
pcre2
];
linuxRpath = lib.makeLibraryPath keytarRuntimeLibs;
modules = (yarn2nix.mkYarnModules {
inherit version;
pname = "${pname}-modules";
Expand All @@ -19,6 +29,7 @@ let
] ++ lib.optionals stdenv.isLinux [
libsecret
glib
patchelf
] ++ osSpecific;
};
sqlite3.buildInputs = [ python3 pkg-config ];
Expand All @@ -30,6 +41,19 @@ let
'';
}).overrideAttrs (old: {
NODE_EXTRA_CA_CERTS = "${cacert}/etc/ssl/certs/ca-bundle.crt";
postFixup = (old.postFixup or "") + lib.optionalString pkgs.stdenv.isLinux ''
echo "Patching RPATH for native addons -> ${linuxRpath}"
while IFS= read -r -d "" f; do
if file "$f" | grep -q ELF; then
old_rpath="$(patchelf --print-rpath "$f" 2>/dev/null || true)"
if [ -n "$old_rpath" ]; then
patchelf --set-rpath "${linuxRpath}:$old_rpath" "$f" || true
else
patchelf --set-rpath "${linuxRpath}" "$f" || true
fi
fi
done < <(find "$out/node_modules" -type f -name '*.node' -print0)
'';
});
in
stdenv.mkDerivation {
Expand Down