Fix masking for fill_value and missing_value for numpy 2.4.0 #304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I merged too fast #303 (like a .303 bullet hehe) but @davidhassell mentioned it's not complete since missing_value could be a multi-dim array, not just a size one, as I thought. This should fix that.
Reminder: numpy 2.4.0 doesn't allow stuff like ma.masked_equal or other such funcs that set fill_values, to have arrays passed for fill_value, eg their deprecation:
This implementation here should be backwards compatible.
Before you get started
Checklist