-
Notifications
You must be signed in to change notification settings - Fork 0
Typescript rewrite #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This is a complete TypeScript rewrite of a Node.js API documentation service, modernizing the codebase from JavaScript/Babel to TypeScript with updated tooling and dependencies.
- Migration from JavaScript with Babel to native TypeScript compilation
- Logger replacement from Bunyan to Pino with improved type safety
- Build system overhaul with Docker multi-stage builds and updated scripts
- Dependencies cleanup removing legacy Babel packages and adding TypeScript tooling
Reviewed Changes
Copilot reviewed 22 out of 27 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/logger.ts | New TypeScript logger implementation using Pino instead of Bunyan |
| src/utils/htmlTemplates.ts | TypeScript conversion with proper type annotations and fixed import typo |
| src/utils/errorHelpers.ts | TypeScript rewrite with improved type safety and error handling |
| src/utils/apiHelpers.ts | TypeScript conversion with enhanced fetch error handling and type definitions |
| src/server.ts | New TypeScript server implementation with graceful shutdown handling |
| src/config.ts | TypeScript configuration with environment-based whitelist parsing |
| src/app.ts | Main Express app converted to TypeScript with proper type annotations |
| src/api/kongApi.ts | TypeScript Kong API client with pagination support and duplicate handling |
| package.json | Major dependency updates for TypeScript tooling and modern Node.js support |
| eslint.config.mjs | New flat ESLint configuration for TypeScript support |
| build.sh | Enhanced build script with TypeScript compilation and improved Docker handling |
| ReadMe.md | Updated documentation reflecting TypeScript migration and new tooling |
| Dockerfile | Multi-stage Docker build optimized for TypeScript compilation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jnatten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bra å få denne over på ts også!
jnatten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Litt vanskelig å reviewe så store PR'er naturligvis, og kanskje enda litt skumlere når det er en ai som har gjort jobben, men siden det som er i master ikke er riktig lenger, så burde vi kanskje bare få inn denne?
Ba copilot om å foreslå oppgradering og fornying av denne. Dette er resultatet.