Skip to content

Conversation

@ChristopherCaradonna
Copy link
Contributor

Pull request overview

This pull request includes 4 new measures for SDR 2025 R3, as well as other postprocessing changes.

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes apptainer image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Pull Request Author Checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added or edited tests for measures that adequately cover anticipated cases
  • New or changed register values reflected in comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • New measure tests add to to test/reporting_measure_tests.txt, test/workflow_measure_tests.txt, or test/upgrade_measure_tests.txt
  • Added 'See ComStock License' language to first two lines of each code file
  • Run rubocop and check log
  • Updated measure .xml(s)
  • Ran 10k+ test run and checked failure rate to make sure no new errors were introduced
  • Measure documentation written or updated
  • ComStock documentation written or updated
  • Change document written and assigned to a reviewer
  • Changes reflected in example .yml files and README.md files

Pull Request Reviewer Checklist:

  • Perform a code review on GitHub
  • All changes have been implemented: data, methods, tests, documentation
  • If fixing a defect, verify by running main branch to reproduce the defect and the PR branch to verify the fix
  • Measure tests written and adequately cover anticipated cases
  • Run measure tests and ensure they pass
  • New measure tests add to to test/reporting_measure_tests.txt, test/workflow_measure_tests.txt, or test/upgrade_measure_tests.txt
  • Ensured code files contain License reference
  • Run rubocop and check log
  • Measure .xml updated
  • CI status: all tests pass
  • ComStock documentation adequately describes the new assumptions
  • Reviewed change documentation, results differences are reasonable, and no new errors introduced
  • Author has addressed comments in change documentation
  • .yml and README.md files updated

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2025 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

kflemin and others added 30 commits August 27, 2025 13:35
* fix missing district emissions in postproc

- add district emissions columns, add to naming mixin, and list downselect option in log

* Update comstock_to_cbecs_comparison.py

Don't try to plot end use stacked bar comparisons unless there are at least 2 discrete values in the groupby column. For now, this means 2 different comstock runs. May edit later to accommodate CBECS.
Turn off equipment counts (HVAC and water heater)
axelstudios and others added 30 commits November 18, 2025 22:00
Fixed Int32/Int64 issue
Add spatial_tract_lookup_table_publish_v10
update hvac system type tsv
…_breakdown

Ccaradoj/sdr 2025 r4 fix other fuel breakdown
…_breakdown

add missing imports, remove duplicate propane and fuel oil columns
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…_plots

Ccaradon/sdr 2025 r4 fix timeseries plots
updates from rubocop based on run with comstock config
Updates after running rubocop with comstock specific config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants