Skip to content

Conversation

@mdahlhausen
Copy link
Contributor

@mdahlhausen mdahlhausen commented Jan 15, 2026

Pull request overview

  • Adds clarification to the sampling error message when a combination does not exist.
  • Adds three system types to the hvac tsvs where needed:
    • DOAS with fan coil air-cooled chiller with central air source heat pump
    • DOAS with fan coil chiller with central air source heat pump
    • PVAV with central air source heat pump reheat

The changed tsvs are:

  • fault_economizer_damper_fully_closed.tsv
  • fault_economizer_db_limit.tsv
  • hvac_night_variability.tsv

Pull Request Author

This pull request makes changes to (select all the apply):

  • Sampling

Pull Request Author Checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Ran sampling test run and checked failure rate to make sure no new errors were introduced

Pull Request Reviewer Checklist:

  • Perform a code review on GitHub
  • All changes have been implemented: data, methods, tests, documentation

- Adds clarification to the sampling error message when a combination does not exist.
- Adds three system types to the hvac sampling tsvs where needed:
  - DOAS with fan coil air-cooled chiller with central air source heat pump
  - DOAS with fan coil chiller with central air source heat pump
  - PVAV with central air source heat pump reheat
@mdahlhausen mdahlhausen requested a review from rHorsey January 15, 2026 18:36
@mdahlhausen mdahlhausen added the sampling PR improves or adds to the sampling methodology label Jan 15, 2026
@rHorsey
Copy link
Collaborator

rHorsey commented Jan 15, 2026

The code changes look good to me - thanks @mdahlhausen . @ChristopherCaradonna do we need to do a 10k test run? Matt's already rerun the 10k sampling and that completes as expected.

Copy link
Contributor

@ChristopherCaradonna ChristopherCaradonna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdahlhausen - what are we assuming for the prevalence of the newly added systems types?

@ChristopherCaradonna
Copy link
Contributor

The code changes look good to me - thanks @mdahlhausen . @ChristopherCaradonna do we need to do a 10k test run? Matt's already rerun the 10k sampling and that completes as expected.

@rHorsey - if we changed HVAC distributions then we should do a test run and change doc.

@mdahlhausen
Copy link
Contributor Author

mdahlhausen commented Jan 16, 2026

@mdahlhausen - what are we assuming for the prevalence of the newly added systems types?

There are no changes to baseline prevalence of HVAC systems in ComStock. I added some missing systems types available in the create typical measure to some tsvs that have a dependency on HVAC system type. In the process, I added a more descriptive error message. I did this because I manually overwrote some HVAC types in a custom bucket sampling definition file with newer all-electric ones not in the HVAC sampling for the Lahaina rebuild project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sampling PR improves or adds to the sampling methodology

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants