Skip to content

Add QP matrix to problem modeling #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Iroy30 wants to merge 10 commits into
base: release/26.02
Choose a base branch
from
Open

Add QP matrix to problem modeling #775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2e8717a
update model to add QP matrix
Iroy30 Jan 14, 2026
42ab2fe
add test and update recipe
Iroy30 Jan 19, 2026
95560f5
Merge branch 'main' into add_QP_matrix
Iroy30 Jan 19, 2026
2a5cf28
add scipy to environments
Iroy30 Jan 19, 2026
c2b2032
Merge remote-tracking branch 'iroy30/add_QP_matrix'
Iroy30 Jan 19, 2026
254a5a9
update dependency
Iroy30 Jan 19, 2026
df85b24
style checks
Iroy30 Jan 21, 2026
9ddfca4
Merge branch 'main' into add_QP_matrix
Iroy30 Jan 21, 2026
806ec8c
update env
Iroy30 Jan 21, 2026
f16a2a9
Merge remote-tracking branch 'iroy30/add_QP_matrix'
Iroy30 Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions conda/environments/all_cuda-129_arch-aarch64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ dependencies:
- requests
- rmm==26.2.*,>=0.0.0a0
- scikit-build-core>=0.11.0
- scipy>=1.13.0
- sphinx
- sphinx-copybutton
- sphinx-design
Expand Down
1 change: 1 addition & 0 deletions conda/environments/all_cuda-129_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ dependencies:
- requests
- rmm==26.2.*,>=0.0.0a0
- scikit-build-core>=0.11.0
- scipy>=1.13.0
- sphinx
- sphinx-copybutton
- sphinx-design
Expand Down
1 change: 1 addition & 0 deletions conda/environments/all_cuda-131_arch-aarch64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ dependencies:
- requests
- rmm==26.2.*,>=0.0.0a0
- scikit-build-core>=0.11.0
- scipy>=1.13.0
- sphinx
- sphinx-copybutton
- sphinx-design
Expand Down
1 change: 1 addition & 0 deletions conda/environments/all_cuda-131_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ dependencies:
- requests
- rmm==26.2.*,>=0.0.0a0
- scikit-build-core>=0.11.0
- scipy>=1.13.0
- sphinx
- sphinx-copybutton
- sphinx-design
Expand Down
1 change: 1 addition & 0 deletions conda/recipes/cuopt/recipe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ requirements:
- pylibraft =${{ minor_version }}
- python
- rmm =${{ minor_version }}
- scipy
Copy link

@coderabbitai coderabbitai bot Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Search for scipy imports in the Python cuopt package
rg -n "import scipy|from scipy" --type py

Repository: NVIDIA/cuopt

Length of output: 257

Addition of scipy dependency is justified.

The scipy dependency is actively used in the Python codebase for sparse matrix operations (scipy.sparse.coo_matrix in python/cuopt/cuopt/linear_programming/problem.py) and spatial distance calculations (scipy.spatial.distance in benchmark utilities). This confirms the addition is appropriate for QP matrix support.

Consider adding a minimum version constraint (e.g., scipy >=1.10) for consistency with other scientific Python dependencies (numpy >=1.23,<3.0, pandas >=2.0) and to ensure compatibility across the dependency stack.

🤖 Prompt for AI Agents 
In `@conda/recipes/cuopt/recipe.yaml` at line 85, Update the conda recipe
dependency for scipy to include a minimum version constraint (e.g., change the
plain "scipy" entry in recipe.yaml to "scipy >=1.10") to ensure compatibility
with code using scipy.sparse.coo_matrix and scipy.spatial.distance; make the
version range consistent with other scientific deps (for example "scipy
>=1.10,<2.0" if you want an upper bound) and update any CI/test environment
metadata to match.

# Needed by Numba for CUDA support
- cuda-nvcc-impl
# TODO: Add nvjitlink here
Expand Down
1 change: 1 addition & 0 deletions dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,7 @@ dependencies:
- numba>=0.60.0
- &pandas pandas>=2.0
- &pyyaml pyyaml>=6.0.0
- scipy>=1.13.0
- output_types: requirements
packages:
# pip recognizes the index as a global option for the requirements.txt file
Expand Down
Loading
Loading