-
Notifications
You must be signed in to change notification settings - Fork 4
Add more info on Web Vitals #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
alea12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jdohan, I think this is a great addition. Do you think it's worth mentioning the performance tab of Chrome dev tools (if not already mentioned elsewhere)? I understand its caveats (extension interference etc.) but always found it as a quick and easy reference.
|
@alea12 that's right! I overlooked that one when listing out the available tools and it definitely is a nice go-to. That reminds me there's also a number of Chrome extensions that support measuring Web Vitals for the current user's session, including the official one developed by Google Core Web Vitals Test (which appears to report the same scores as dev tools, thankfully). I'll add Chrome dev tools and the extension to the list of services under the Measuring Web Vitals section.
|
EdwinGuzman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just some minor comments.
| - Cumulative Layout Shift (CLS) | ||
| - Speed Index (SI) | ||
| - Time to First Byte (TTFB) | ||
| High-level Metrics developed by Google that quantify front-end application UX (defined at [web.dev](https://web.dev/articles/vitals)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit nitpicky wording, but the web vitals is to quantify loading, interactivity, and visual rendering of web pages for UX (like you mention below). It doesn't cover accessibility, content, user flow, etc, which are other aspects of frontend application UX. Perhaps reword to be slightly more precise to not imply it covers and quantifies all FE application UX.
| - **LoadForge**: Performance monitoring features that include Core Web Vitals scores | ||
| - **New Relic Browser**: Collects data from actual users over the last 7 day period | ||
|
|
||
| PageSpeed Insights is the preferred tool for measuring Web Vitals. It is free to use, has an [API](https://developers.google.com/speed/docs/insights/v5/get-started) that can be used for automating lab measurements, and provides actionable suggestions for improving low scores. Tests can be run on demand against any URL, which is especially valuable in pre-production environments since they have little or no real user traffic (and thus limited field data), making lab measurements from PageSpeed Insights the primary way to evaluate and tune performance before release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the preferred tool but is it also the recommended tool for NYPL sites?
This may not be the place for this but if I have a project coming up and I want the QA engineering on my team to run web vital tests, I'd like to see which is the recommended tool. Ideally, it would also be the standard tool used across other teams so we're all using the same one. Just an idea but not a blocker for this PR.


Adds more information in the Web Vitals section in addition to some miscellaneous improvements and corrections.