SFR-2592: Update <Document> type to support File type from react-pdf #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atch the `file` props used for rendering the pdf
Toxiapo
requested review from
jackiequach,
kristojorg,
oliviawongnyc and
samanthaandrews
as code owners
Toxiapo
changed the title
jackiequach
approved these changes
Apr 8, 2025
Collaborator
jackiequach
left a comment
jackiequach
left a comment
There was a problem hiding this comment.
looks good, just some minor non-blocking comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the file prop type to align with react-pdf, allowing the consumer app to choose a different downloading strategy. By default, when the file prop is provided as a URL string, React-pdf will download and render the PDF content in chunks.
Additionally, I've added a new route,
Fetch PDF URL - Webpub, which eliminates the need to construct a TOC for the manifest, this step will eventually be handled by the backend. I’ve also added a customgetContentfunction to return a URL string to replace the default function that is currently returns Uinit8Array.Tested on a 1.2G linearized PDF:
Before:
After: