Skip to content

python310Packages.readchar: run tests on Darwin #217970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mweinelt merged 1 commit into from
Feb 26, 2023
Merged

python310Packages.readchar: run tests on Darwin #217970

mweinelt merged 1 commit into from
Feb 26, 2023

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Feb 24, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from FRidh as a code owner February 24, 2023 05:38
@dotlambda dotlambda requested a review from jonringer as a code owner February 24, 2023 05:38
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 24, 2023
@dotlambda dotlambda requested a review from mmahut February 24, 2023 05:39
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Feb 24, 2023
@dotlambda dotlambda requested a review from mweinelt February 26, 2023 01:42
dotlambda
dotlambda commented Feb 26, 2023
View reviewed changes
@mweinelt mweinelt merged commit 2a1538d into NixOS:master Feb 26, 2023
@dotlambda dotlambda deleted the readchar-darwin branch February 27, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@mmahut mmahut Awaiting requested review from mmahut

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dotlambda @mweinelt