Skip to content

Conversation

@ErwanRaulo
Copy link
Contributor

@ErwanRaulo ErwanRaulo commented Jan 4, 2026

command allows the following spec arguments:

  • undefined: leading to an error on string.match fn
  • express: leading to a null version after spec parsing and thus to a 404 from registry API
  • something invalid to parse: that just throw an error

to do:

  • log user friendly i18n error message about arguments
    example:
image
  • handle arguments unexpected values
  • add more unit tests

what could be better ?:

  • migrate commands to typescript strict mode

@codecov
Copy link

codecov bot commented Jan 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.46%. Comparing base (28ee6a9) to head (24b54f5).
⚠️ Report is 301 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (28ee6a9) and HEAD (24b54f5). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (28ee6a9) HEAD (24b54f5)
6 3
Additional details and impacted files
@@             Coverage Diff              @@
##            master     #647       +/-   ##
============================================
- Coverage   100.00%   59.46%   -40.54%     
============================================
  Files           15       46       +31     
  Lines          649     3498     +2849     
  Branches         0       15       +15     
============================================
+ Hits           649     2080     +1431     
- Misses           0     1418     +1418     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ErwanRaulo ErwanRaulo force-pushed the fix/extract-integrity branch 4 times, most recently from b54566e to 9948879 Compare January 4, 2026 19:24
@ErwanRaulo ErwanRaulo force-pushed the fix/extract-integrity branch from 9948879 to c9390b3 Compare January 4, 2026 23:13
@ErwanRaulo ErwanRaulo marked this pull request as ready for review January 4, 2026 23:19
@ErwanRaulo ErwanRaulo force-pushed the fix/extract-integrity branch from c79ef22 to 24b54f5 Compare January 4, 2026 23:24
@fraxken fraxken merged commit f6396e1 into NodeSecure:master Jan 5, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants