-
-
Notifications
You must be signed in to change notification settings - Fork 532
[18.0][IMP] queue_job: requeue orphaned jobs #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
|
Hi @guewen, |
sbidoul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I kind of remember we had thought about this case when doing the original implementation with @AnizR but maybe it got lost in the various iterations we did.
8b82098 to
84a3fca
Compare
In deed, we talked about it but I think that it got lost. Thanks for this patch, I'll review it within the week. |
|
@sbidoul are we good to merge? |
This pr add a secondary attempt to requeue "orphaned jobs" where it stucks in enqueued, not yet make it to queue_job_lock and selecting jobs after db initialization also misses it. Even a server restart would not unblock the job.
This is most likely due to server being shutdown or crash during job enqueue. Manually requeue the job on UI make everything running again.