fix: Console error on loading SR report #5600
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
nithin-trenser
changed the title
sedghi
reviewed
Dec 1, 2025
|
|
||
| const { ValueType } = ContentSequence; | ||
| if (!ValueType === 'SCOORD') { | ||
| if (ValueType !== 'SCOORD') { |
Contributor
There was a problem hiding this comment.
@sedghi We do support both SCOORD3D and SCOORD. Maybe we need to update to only return if not both?
Contributor
Author
There was a problem hiding this comment.
@igoroctaviano Code updated to support both SCOORD3D and SCOORD.
igoroctaviano
requested changes
Dec 1, 2025
|
|
||
| const { ValueType } = ContentSequence; | ||
| if (!ValueType === 'SCOORD') { | ||
| if (ValueType !== 'SCOORD') { |
Contributor
There was a problem hiding this comment.
@sedghi We do support both SCOORD3D and SCOORD. Maybe we need to update to only return if not both?
sedghi
approved these changes
Dec 9, 2025
sedghi
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Resolved the console error that occurred after generating the SR report using the updated structure introduced in the dcmjs PR. This error was present earlier but surfaced only with the recent SR report modifications.
Changes & Results
chrome_0LEUunrk6R.mp4
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment