-
Notifications
You must be signed in to change notification settings - Fork 105
tests: add DPDK segmented mbufs test #2835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| @@ -0,0 +1,2317 @@ | |||
| %YAML 1.1 | |||
| --- | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please provide minimal YAML file to test this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
| requires: | ||
| min-version: 8 | ||
| features: | ||
| - DPDK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be HAVE_DPDK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha, ok, false. It is as it should be.
Perhaps a question for @jasonish -- I don't see DPDK in the "Features" list as noted at the bottom of the https://github.com/OISF/suricata-verify/ readme page. Does it now take this information from elsewhere as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work. run.py supports parsing --build-info lines like:
DPDK support: yes
This test runs for me when I use the linked Suricata PR with DPDK support enabled, however, it fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why it fails, as it passes on my end, can you please run the test with verbose mode and share logs?
|
I would be happy to see a test that shows and confirms the failing linearization. After the YAML change is done, it is good for me. |
Add test to verify Suricata correctly handles segmented (chained) mbufs in DPDK mode. Uses large TLS packets that force mbuf segmentation. Ticket: 6012 Signed-off-by: mmaatuq <mmaatuq3@gatech.edu>
19c7576 to
310e34b
Compare
| @@ -0,0 +1,26 @@ | |||
| requires: | |||
| min-version: 8 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to change this to:
min-version: 9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As / if it will be backported to 8 then we can lower the version
Add test to verify Suricata correctly handles segmented (chained)
mbufs in DPDK mode. Uses large TLS packets that force mbuf
segmentation.
Ticket: 6012
Redmine ticket:https://redmine.openinfosecfoundation.org/issues/6012