-
Notifications
You must be signed in to change notification settings - Fork 2
Add PTirc IRC Network to servers.json #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughA new IRC server entry for "PTirc IRC Network" is added to the servers.json file, including server address, port, description, and obsidian flag configuration. The existing entries remain unchanged. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
servers.json(1 hunks)
🔇 Additional comments (1)
servers.json (1)
29-29: LGTM!The comma is correctly added to maintain valid JSON syntax when appending a new array element.
| { | ||
| "name": "PTirc IRC Network", | ||
| "description": "Multi purpose chat network.", | ||
| "server": "irc.ptirc.org", | ||
| "port": "7666", | ||
| "obsidian": false | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the port number for PTirc IRC Network.
The server address irc.ptirc.org is correct, but the port is incorrect. The correct port is 6697 with SSL/TLS encryption. Change port from 7666 to 6697.
🤖 Prompt for AI Agents
In servers.json around lines 30 to 36, the PTirc IRC Network entry currently
uses port "7666"; update the port value to "6697" and keep the same value type
(string) to match the file style, and add an explicit TLS flag (e.g., "tls":
true) to indicate SSL/TLS encryption for this server entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TehPeGaSuS, thank you for the clarification! You're absolutely right - I incorrectly assumed this was a traditional IRC port. Since port 7666 is the WebSocket port for PTirc IRC Network, the configuration is correct as is. I apologize for the confusion.
✏️ Learnings added
Learnt from: TehPeGaSuS
Repo: ObsidianIRC/server-list PR: 3
File: servers.json:30-36
Timestamp: 2025-12-19T22:55:13.326Z
Learning: PTirc IRC Network uses port 7666 as a WebSocket port for IRC connections in servers.json, which is correct and should not be changed to standard IRC ports like 6697.
Learnt from: TehPeGaSuS
Repo: ObsidianIRC/server-list PR: 3
File: servers.json:30-36
Timestamp: 2025-12-19T22:55:13.326Z
Learning: IRC networks in servers.json can use WebSocket ports in addition to traditional IRC ports (6667, 6697, etc.), so port numbers should not be assumed to follow only standard IRC port conventions.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.