Fixes self-closing html tag check, interprets br as newline #2482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Ruzihm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in maptext html parsing, if a self-closing tag such as
<br>is written using the self-closing slash without a space in between:<br/>the parser breaks:To reproduce this, go into (goon's) cogmap2 and visit the QM office. your client will get spammed by the above message when the market shift status display is visible.
This MR fixes this particular parsing issue by checking for a trailing
/character at the end of the tag name or last parameter.It also makes a change to how
<br>tags specifically are handled. Instead of pushing encountered<br>tags as markup nodes, they are instead converted into newlines and appended to the text of the currently active tag. This results in a slightly more correct rendering: