Forma mirroring #26
Open
Forma mirroring #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aashkann
reviewed
Feb 20, 2024
Contributor
aashkann
left a comment
aashkann
left a comment
There was a problem hiding this comment.
Just want to check on the small grid dimensions.
Components/GH_terrainArrays.cs
Outdated
| Rhino.Geometry.Mesh ProbMesh = CreateMeshFromGridPoints(HitPoints(analysisPoints, terrainToMesh),201,201); | ||
|
|
||
| //Rhino.Geometry.Mesh ProbMesh = CreateMeshFromGridPoints(HitPoints(analysisPoints, terrainToMesh),201,201); | ||
| Rhino.Geometry.Mesh ProbMesh = CreateMeshFromGridPoints(HitPoints(analysisPoints, terrainToMesh), 200, 200); |
Contributor
There was a problem hiding this comment.
@MikaelSpinnangr I think we need 201x201 to perform the operation. Was there any reason that you changed this?
Contributor
Author
There was a problem hiding this comment.
You are right, I changed the getanalysispoint method and i was thinking of the mesh instead of the points, let me change that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the grids similar to forma
My firewall is killing me would be nice if you could test this
I will try to figure out a way around it.