-
Notifications
You must be signed in to change notification settings - Fork 10
update ligandnetwork generation notebooks #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
195fa0f to
4427ece
Compare
|
Some migration from OpenFreeEnergy/konnektor#200, but generally minor changes. |
|
related: OpenFreeEnergy/gufe#692 and OpenFreeEnergy/openfe#1750 |
f0b882c to
3ee90e0
Compare
2b656c0 to
ff4a545
Compare
|
View / edit / reply to this conversation on ReviewNB jthorton commented on 2026-01-08T11:38:30Z Do we want some more details on what we are trying to show in the notebook, it might be good so users can quickly tell if this is relevent to them, we also might want to point to the konnector docs for more examples and details on the networks available. atravitz commented on 2026-01-09T17:14:57Z ah, I missed carrying over the title cell from konnektor! and now that I'm looking at this again, I think maybe it should actually live in konnektor docs with kartograf as a dep only for the tutorial notebooks. IAlibay commented on 2026-01-09T17:39:52Z I think either way works tbh - we want to encourage folks to use konnektor, so whichever is easiest! atravitz commented on 2026-01-09T21:58:39Z okay, let's keep it here so that konnektor is completely independent of kartograf for now! |
|
ah, I missed carrying over the title cell from konnektor! and now that I'm looking at this again, I think maybe it should actually live in konnektor docs with kartograf as a dep only for the tutorial notebooks. View entire conversation on ReviewNB |
|
I think either way works tbh - we want to encourage folks to use konnektor, so whichever is easiest! View entire conversation on ReviewNB |
IAlibay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside from josh's comments - this looks good to me
|
okay, let's keep it here so that konnektor is completely independent of kartograf for now! View entire conversation on ReviewNB |
related to: OpenFreeEnergy/konnektor#169
and OpenFreeEnergy/konnektor#200