-
Notifications
You must be signed in to change notification settings - Fork 272
cgroups: refactor cgroups #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
f213f8d to
d097cab
Compare
|
It'd be easier to review (and cleaner git log for reading and/or bisecting) if the cosmetic changes and functional changes were separated into different commits. |
d097cab to
94c9345
Compare
tried my best to split them, tho 4/5 will still be a big commit since it changes the internal cgroups api |
94c9345 to
9931622
Compare
That's fine. I don't suggest splitting needlessly just to reduce commit size. If a cosmetic change unintentionally changes functionality then it's not immediately obvious whether it was intentional or not if it's lumped into a functional commit. Having them on their own commit makes this clearer. |
move into a new layout with a supervision root cgroup as /rc, services will then go in /rc/$RC_SVCNAME, and compatibility with the old /openrc.$RC_SVCNAME is kept though restarting a service will use the new layout this also fixes a bug where cgroup_cleanup would not ever trigger due to a bug in cgroup_running
9931622 to
4a30051
Compare
add a deprecation warning for cgroups v1, and rework rc-cgroups.sh into cgroups.sh with an api focused on cgroups v2
move into a new layout with a supervision root cgroup as /rc, services will then go in /rc/$RC_SVCNAME, and compatibility with the old /openrc.$RC_SVCNAME is kept though restarting a service will use the new layout
this also fixes a bug where cgroup_cleanup would not ever trigger due to a bug in cgroup_running
i'll also add support for cgroups in user services to this PR later