chore: python project migration to uv #20135
Open
+26,266
−28,527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
requested changes
Nov 14, 2025
Member
sfoster1
left a comment
sfoster1
left a comment
There was a problem hiding this comment.
let's try and do all we can to avoid changes that aren't necessary for the uv cutover. that's stuff like
- Altering the
pipenv_optsdefinition requiring changes to all the makefiles to push--devup - Whatever is causing the typechecking to change and requiring some extra
casts - Whatever made us reformat
ot3controller.py
There's also some other little stuff:
- is there ever a time we would not want to install dev dependencies? can we just remove that argument to the action, or invert it to
no-install-dev-depsand specify it more rarely? - let's rely on python depspecs for the linux only dependencies
- some code duplication around path specification i think we can pull
- let's just double check that the versions of all the dependencies, including dev dependencies, are the same in the new uv and the old pipenv dependency specs. that will let us change fewer things at one time
| id: project-type | ||
| shell: bash | ||
| run: | | ||
| # Only api and shared-data use UV for now |
Member
There was a problem hiding this comment.
can we probe for the existence of a uv.lock file instead, or even cut over the makefile
Collaborator
Author
There was a problem hiding this comment.
More than just the 2 projects we are looking at have uv.lock, it's not a good indicator.
y3rsh
reviewed
Nov 14, 2025
y3rsh
reviewed
Nov 14, 2025
y3rsh
reviewed
Nov 14, 2025
y3rsh
reviewed
Nov 18, 2025
y3rsh
reviewed
Nov 18, 2025
y3rsh
reviewed
Nov 18, 2025
y3rsh
reviewed
Nov 18, 2025
y3rsh
reviewed
Nov 18, 2025
y3rsh
reviewed
Nov 18, 2025
y3rsh
reviewed
Nov 21, 2025
y3rsh
reviewed
Nov 21, 2025
y3rsh
reviewed
Nov 21, 2025
y3rsh
reviewed
Nov 21, 2025
sfoster1
requested changes
Nov 24, 2025
Member
sfoster1
left a comment
sfoster1
left a comment
There was a problem hiding this comment.
Very much getting there! A couple little nits to pick; the only big things left are some github actions stuff, the thing with the mypy configuration in api, and a weirdness with the dependencies in api.
sfoster1
changed the title
Added imports for referencing added --dev back referencing
more squashed commits
neo-jesse
force-pushed
the
api-and-shared-uv-migration
branch
from
ab14763 to
433422a
Compare
* fix(app): fix command step height issue
…20208) * fix(components): fix timeline scrubber's background hover behavior
…art of QuickTransferSummaryState (#20212) # Overview This is a type-hinting change to tell TypeScript that the `aspirateState`/`dispenseState` in `retrieveLiquidClassValues.ts` is part of `QuickTransferSummaryState`. Without this, VS Code doesn't find this file when we're looking for places that touch `.disposalVolumeDispenseSettings`, wasting a lot of time for programmers trying to find what is setting that field. Adding this annotation also helps TypeScript catch typos. For example, if this file had accidentally misspelled the field as `disposalVolumeDispenseSettingsxx`, TypeScript would now complain about it. ## Test Plan and Hands on Testing Just run CI. ## Risk assessment Very low. No functional change whatsoever.
Correctly use `set_load_module` for StateUpdate when mapping 2.13 and below PAPI load module calls
The other projecs use more recent flake8, let's do it here too.
Lets us tell which labware fails.
) This PR was requested on the PR #20109 Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com>
With the decision to treat Quick Transfer protocols more like standard protocols, we want to show them in the desktop app's `RecentProtocolRuns` component. This also allows us to view and download any files from the run, which as of now would include photos taken during any potential error recovery. There are also a few instances in ODD where we implicitly delete QT runs. We don't want to do this!
# Overview Moved run status utils into `local-resources` since they are used across platforms in the app Replaced the majority of instances of bare `runStatus` strings with utils ## Changelog - moved utils from `ProtocolHeader` to `local-resources` - fixed conditional bug that was preventing you from restarting a run due to the robot being in idle state ## Test Plan and Hands on Testing - smoke tested various places of app and odd ## Review requests - Double check run status groupings aren't repeated - Double check majority of run status bare string usage is addressed ## Risk assessment medium - touches a lot of code but does not change functionality Closes second half of EXEC-1478
…ls (#20197) # Overview Camera, concurrent modules, and dynamic liquid tracking implemented into active ABR protocols ## Test Plan and Hands on Testing - All protocols simulate - `TODO:` protocols with the tc lid and dynamic liquid tracking have not been tested on a robot yet ## Changelog - also added a robot log script to compare duration of protocol commands ## Review requests @ryanthecoder when implementing the dynamic pipetting, there were a couple spots I needed to add `prepare_to_aspirate()` before a dynamic aspirate to avoid getting this error: ``` ProtocolCommandFailedError [line 1035]: Error 4000 GENERAL_ERROR (ProtocolCommandFailedError): PipetteNotReadyToAspirateError: Pipette cannot aspirate while tracking because a previous dispense or blowout pushed the plunger beyond the bottom position. The subsequent aspirate must be from a specific well so the plunger can be reset in a known safe position. ``` Is this expected? ## Risk assessment medium until the protocols are run on the robot
…ges (#20299) Closes RQA-4941 Axios cannot return Blob types when in a Node.js environment (there is no native blob type in the version of Axios we use), and Electron's IPC mechanism does not properly serialize Blob objects into strings anyway. To fix, on the node layer we can request an ArrayBuffer type instead, transform it to an Array type, and then send this data across the IPC as it becomes perfectly serializable. We can then parse this Array type back into a Blob on the browser layer. Note that downloading images works perfectly fine - it's just an issue whenever we request the raw image files themselves.
* feat(app): add Skeleton component for second window
* fix(app): remove number from individual command
# Overview Add non functional livestream image capture button hidden behind the camera settings feature flag ## Test Plan and Hands on Testing Smoke tested on ODD w/o feature flag on <img width="491" height="430" alt="Screenshot 2025-12-04 at 2 56 59 PM" src="https://github.com/user-attachments/assets/750a5315-4eee-4dbc-8a8d-698d8784683a" /> ## Review requests ## Risk assessment low Closes EXEC-2101
…are (#20253) # Overview PR for touch probe proof of concept. Adds firmware, drivers, and hardware testing scripts for the touch probe. https://docs.google.com/document/d/151cAolVlUmFbdYdXOCe5GIgDmzycKI_iPKSS7zWbS0I/edit?tab=t.0 ## Changelog -added touch probe firmware + drivers -added touch_probe mock scripts to hardware testing --------- Co-authored-by: Ryan Howard <ryan.howard@opentrons.com> Co-authored-by: Rhyann Clarke <146747548+rclarke0@users.noreply.github.com> Co-authored-by: Rhyann Clarke <rhyann.clarke@opentrons.com>
#20311) * fix(components): fix primarybutton and alt primarybutton styling issue
…are (#20253) PR for touch probe proof of concept. Adds firmware, drivers, and hardware testing scripts for the touch probe. https://docs.google.com/document/d/151cAolVlUmFbdYdXOCe5GIgDmzycKI_iPKSS7zWbS0I/edit?tab=t.0 -added touch probe firmware + drivers -added touch_probe mock scripts to hardware testing --------- Co-authored-by: Ryan Howard <ryan.howard@opentrons.com> Co-authored-by: Rhyann Clarke <146747548+rclarke0@users.noreply.github.com> Co-authored-by: Rhyann Clarke <rhyann.clarke@opentrons.com>
Numpy 1.26.4 doesn't have a precompiled wheel for python 3.13, so when you install it pip will build it locally. This takes a while, but also creates a bad object on windows since numpy doesn't support mingw.
more squashed commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Python dependency management from Pipenv to UV
Summary
Migrates
apiandshared-dataprojects frompipenvtouvfor faster dependency resolution and installation. All other projects continue usingpipenv.Key Changes for Api and shared-data
apiandshared-datafromPipfiletopyproject.tomlwithuv.lockscripts/python-uv.mkfor UV projects;scripts/python.mkremains for pipenv projectsopentrons-hardware[FLEX]to api dev deps,numpyto shared-data main depsjsonschema.RefResolvertoreferencinglibraryinstall-uv,cache-uv,setup)uvin Make commandsinstall-dev-deps: 'true'to workflows that run lint/test for UV projectsChanges for Pipenv Projects
pipenv sync --devto ensure dev dependencies are installedBenefits
apiandshared-datapyproject.tomlconfiguration for migrated projects