refactor(step-generation, shared-data): use set_stored_labware_items and fill_items

[jerader]

closes EXEC-2102

Overview

Emit fill_items() and set_stored_labware_items() instead of fill() and set_stored_labware(). you can't smoke test this yet though

Also i reverted retrieve() back to before lol.

This change came from the meeting today:

Example code we should get from this:

plate_1 = load_labware(location: offDeck)
plate_2 = load_labware(location: offDeck)
stacker_1 = load_module()
stacker_1.set_stored_labware_items([plate_1])
stacker_1.retrieve() // retrieve plate_1
stacker_1.fill_items([plate_2])
stacker_1.retrieve() // retrieve plate_2

Test Plan and Hands on Testing

review the code. i didn't wire up fill_items() state update - i'll do that later on when we have things more wired up.

you can actually test emitting set_stored_labware_items() though!

Changelog

add the missing types
refactor fill and set stored labware utils
add test cases

Risk assessment

low

[codecov]

Codecov Report

❌ Patch coverage is 85.18519% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.58%. Comparing base (abc2673) to head (2cf4e98).
⚠️ Report is 1 commits behind head on edge.

Files with missing lines	Patch %	Lines
...neration/src/getNextRobotStateAndWarnings/index.ts	25.00%	6 Missing ⚠️
...src/getNextRobotStateAndWarnings/stackerUpdates.ts	16.66%	5 Missing ⚠️
step-generation/src/utils/pythonFileUtils.ts	96.42%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             edge   #20293      +/-   ##
==========================================
- Coverage   25.59%   25.58%   -0.01%     
==========================================
  Files        3636     3641       +5     
  Lines      303087   303341     +254     
  Branches    42340    42355      +15     
==========================================
+ Hits        77560    77603      +43     
- Misses     225503   225714     +211     
  Partials       24       24              

Flag	Coverage Δ
protocol-designer	19.35% <14.81%> (+<0.01%)	⬆️
step-generation	5.62% <83.95%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...src/commandCreators/atomic/flexStackerFillItems.ts	100.00% <100.00%> (ø)
.../src/commandCreators/atomic/flexStackerRetrieve.ts	100.00% <100.00%> (ø)
step-generation/src/utils/pythonFileUtils.ts	88.14% <96.42%> (+0.14%)	⬆️
...src/getNextRobotStateAndWarnings/stackerUpdates.ts	87.70% <16.66%> (-2.47%)	⬇️
...neration/src/getNextRobotStateAndWarnings/index.ts	69.33% <25.00%> (-0.97%)	⬇️

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[TamarZanzouri]

looks good! had a few questions but this is good to merge once we get those questions answered :-)

[ddcc4]

Out of curiosity: Is the PD UI not going to ask the user for a string so that the user has something to look at when the ODD prompts them to fill the hopper? (The message arg to fill_items().)

[jerader]

ooooh this is an option, yes. i'll add the message arg

[ddcc4]

Thanks!

[ddcc4]

Again, we should really change this to the oldest API version that supports all the code that PD generates.

[jerader]

good point, i thought i needed to update it for the _items() but i can revert it

[ddcc4]

So for this particular PD release, let's bump it up to API 2.28, because @jbleon95 added a new feature to make LC transfers more efficient that's enabled in 2.28.

But I meant that we should update the comment to say pick the oldest API version that has the features we need, rather than the latest API version.

[ddcc4]

What is this for? Under what condition would something be onAdapter and isLabwareOnHopper?

And if something is on an adaptor and in the hopper, wouldn't you still want its parent to be the adaptor?

[jerader]

ya i need to fix the onAdapter name. it actually means, onLabware either an adapter or a stack of labwares.