feat(protocol-designer, step-generation): Generate hopper full error on fill and store stacker steps #20329
+245
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rclarke0
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## edge #20329 +/- ##
==========================================
- Coverage 25.58% 25.08% -0.51%
==========================================
Files 3636 3635 -1
Lines 302933 302887 -46
Branches 42346 42423 +77
==========================================
- Hits 77520 75972 -1548
- Misses 225389 226887 +1498
- Partials 24 28 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jerader
reviewed
Dec 9, 2025
|
|
||
| export const flexStackerHopperFull = (): CommandCreatorError => { | ||
| return { | ||
| type: 'HOPPER_FULL', |
Collaborator
There was a problem hiding this comment.
can you add this to the i18n file as well? I think it is alert.json
jerader
reviewed
Dec 9, 2025
| ...(count != null ? [`count=${count}`] : []), | ||
| ...(message != null ? [`message=${formatPyStr(message)}`] : []), | ||
| ] | ||
| // TODO: add mismatched labware error ? |
Collaborator
There was a problem hiding this comment.
oh ya we probably do want the mismatch labware error in here too!
…for mismatched labware and description for full hopper
jerader
reviewed
Dec 9, 2025
step-generation/src/utils/misc.ts
Outdated
| const maximumAllowedLabware = stackerState?.maxPoolCount ?? 0 | ||
| const labwareStored = stackerState?.labwareInHopper | ||
| const numberOfLabwareStored = labwareStored?.length ?? 0 | ||
| return numberOfLabwareStored + 1 < maximumAllowedLabware |
Collaborator
There was a problem hiding this comment.
i think we don't need this +1. We're checking if there is space in the hopper at all at this point. With the +1, you could add 1 too many labwares, right?
Suggested change
| return numberOfLabwareStored + 1 < maximumAllowedLabware | |
| return numberOfLabwareStored < maximumAllowedLabware |
Contributor
Author
There was a problem hiding this comment.
oh yes you are right over thought this one!
jerader
reviewed
Dec 9, 2025
Comment on lines
30
to
46
| if (labwareToStore) { | ||
| for (const labware of labwareToStore) { | ||
| if ( | ||
| labwareMatchesLabwareInHopper( | ||
| labware.primaryLabwareId, | ||
| invariantContext, | ||
| flexStackerState | ||
| ) | ||
| ) { | ||
| continue | ||
| } else { | ||
| return { | ||
| errors: [errorCreators.flexStackerLabwareTypeMismatch()], | ||
| } | ||
| } | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
this way totally works! but it is a bit cleaner, imo, to use .every()
Suggested change
| if (labwareToStore) { | |
| for (const labware of labwareToStore) { | |
| if ( | |
| labwareMatchesLabwareInHopper( | |
| labware.primaryLabwareId, | |
| invariantContext, | |
| flexStackerState | |
| ) | |
| ) { | |
| continue | |
| } else { | |
| return { | |
| errors: [errorCreators.flexStackerLabwareTypeMismatch()], | |
| } | |
| } | |
| } | |
| } | |
| if (labwareToStore) { | |
| const allMatch = labwareToStore.every(labware => | |
| labwareMatchesLabwareInHopper( | |
| labware.primaryLabwareId, | |
| invariantContext, | |
| flexStackerState | |
| ) | |
| ) | |
| if (!allMatch) { | |
| return { | |
| errors: [errorCreators.flexStackerLabwareTypeMismatch()], | |
| } | |
| } | |
| } |
jerader
approved these changes
Dec 9, 2025
Collaborator
jerader
left a comment
jerader
left a comment
There was a problem hiding this comment.
nice job! just left a few minor comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Generate hopper full error on fill and store steps
Test Plan and Hands on Testing
Changelog
Risk assessment
low
Partially closes EXEC-1448