Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Dec 9, 2025

Overview

fix LabwareSlot layout in the Second window

Screenshot 2025-12-09 at 12 01 17 PM

in terms of logic, I will create hooks after DQA.

close RQA-4882 since it requires to update all components for the Second window

Test Plan and Hands on Testing

  • select a protocol
  • click visualization button
  • click a slot that has a labware

Changelog

  • create a new component LabwareSlot for the second window and add its test
  • update the spotlight rendering strucutre to make mantainance easier

List changes introduced by this PR considering future developers and the end user. Give careful thought and clear documentation to breaking changes.

Review requests

Risk assessment

low

@koji koji requested review from jerader and ncdiehl11 December 9, 2025 17:34
@koji koji marked this pull request as ready for review December 9, 2025 17:35
@koji koji added the authorship label Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 78.34395% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.08%. Comparing base (a6255d4) to head (dc7346e).
⚠️ Report is 3 commits behind head on edge.

Files with missing lines Patch % Lines
...esktop/ProtocolVisualization/SlotDetails/index.tsx 0.00% 36 Missing ⚠️
...olVisualization/SecondWindow/LabwareSlot/index.tsx 80.00% 29 Missing and 2 partials ⚠️
.../src/secondary-windows/step-detail-viewer/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #20332       +/-   ##
===========================================
+ Coverage   25.57%   57.08%   +31.50%     
===========================================
  Files        3636     3642        +6     
  Lines      302862   303997     +1135     
  Branches    42331    42906      +575     
===========================================
+ Hits        77449   173522    +96073     
+ Misses     225389   130244    -95145     
- Partials       24      231      +207     
Flag Coverage Δ
app 46.42% <78.34%> (+45.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...dWindow/LabwareSlot/__tests__/LabwareSlot.test.tsx 100.00% <100.00%> (ø)
.../src/secondary-windows/step-detail-viewer/index.ts 0.00% <0.00%> (ø)
...olVisualization/SecondWindow/LabwareSlot/index.tsx 80.00% <80.00%> (ø)
...esktop/ProtocolVisualization/SlotDetails/index.tsx 2.22% <0.00%> (+2.22%) ⬆️

... and 1858 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants