-
Notifications
You must be signed in to change notification settings - Fork 187
refactor(protocol-deisgner): prevent pipetting into shuttle and allow… #20337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: edge
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## edge #20337 +/- ##
==========================================
+ Coverage 25.58% 25.64% +0.06%
==========================================
Files 3640 3641 +1
Lines 303120 303794 +674
Branches 42327 42612 +285
==========================================
+ Hits 77552 77922 +370
- Misses 225544 225848 +304
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| !getIsAdapterFromDef(labwareDef) && | ||
| !isLidOnSlot | ||
| !isLidOnSlot && | ||
| !isStackerInSlot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the boolean value that you're returning mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the boolean is true, we show the transfer/mix step buttons in the add step overflow menu. if its false, we don't show those buttons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, and you want it to work this way because:
- Let's say there's a well plate in C4.
- And there's also a Stacker in C4.
You want to say that this well plate is not PresentForLiquidHandling?
What if the well plate is sitting on the shuttle? Is the well plate available for liquid handling in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you want it not to be available, given the PR description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, its mainly for if you don't have any labware available to pipette into, the button is filtered out.
| const isTopOfStack = fullStackFromLabwares[0] === labwareId | ||
| const topId = fullStackFromLabwares[0] | ||
| const isOnShuttle = stackerModuleIds.some(stackerModule => | ||
| fullStackFromLabwares.includes(stackerModule.slot) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this know it's not on the hopper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call, i should name it more generic, it is filtering for any labware on the flex stacker, not just the shuttle.
… moving to shuttle
closes EXEC-2122
Overview
wow, you can now move labware to the shuttle in a move step and you cannot pipette into labware in the shuttle in a transfer and mix step
Test Plan and Hands on Testing
test that you can move in and out of the shuttle and that you cannot pipette into a labware on the shuttle for transfer and mix steps
Changelog
add logic to the dropdown menu options to account for labware in shuttle and add lgoic to the add button step
Risk assessment
low