Move the default endpoint creation to the ConnectionManager #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move-the-default-endpoint
Contributor
Author
|
Changes since last commit: Rebase after merge of #15 |
|
SonarCloud Quality Gate failed.
|
Jodo1985
approved these changes
Sep 17, 2020
| public class ConnectionManager { | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(ConnectionManager.class); | ||
| /** The default endpoint URI */ | ||
| private static final String DEFAULT_HIVE_API_URI = "https://api.hive.blog/"; |
Collaborator
There was a problem hiding this comment.
we also do not destinguish between static and member variables in terms of naming conventions? (e.g. prefix 's' for static variables?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #26 - Review and merge that one first
Fixes #25
This solves #26 by moving the default endpoint and the client creation to the constructor of the 'ConnectionManager' to avoid that HiveJConfig has to be called/initialized.
Still a bit unsure if this is a propper design or if we should just skip the idea of a default endpoint and let the enduser add those.