Correctness check #132
Merged
Correctness check #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@ZoroZhao Hi Yinjie, there seems to be correctness check failures. Can you investigate the root cause? |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a correctness checking system for TrainCheck, including CI automation and improved error handling. The changes add validation assertions, adjust logging levels for better debugging, and establish automated correctness verification.
- Adds assertion for null-check validation in function call processing
- Changes logging level from warning to debug for missing tensor values
- Implements GitHub Actions workflow for automated correctness checks
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| traincheck/onlinechecker/streamhandler_filesystem.py | Adds assertion to validate pre_record exists before processing post records |
| traincheck/invariant/consistency_transient_vars.py | Changes log level from warning to debug for missing tensor values |
| README.md | Adds correctness check badge to documentation |
| .github/workflows/correctness_checks.yml | Creates CI workflow for automated correctness validation |
Collaborator
Author
I have fixed this. The reason is related to the order of os.listdir in different os. |
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.