Skip to content

Migration: Clean Architecture #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JeelDobariya38 merged 120 commits into from
Dec 15, 2025
Merged

Migration: Clean Architecture #53

JeelDobariya38 merged 120 commits into from
Dec 15, 2025

Conversation

@JeelDobariya38
Copy link
Member

@JeelDobariya38 JeelDobariya38 commented Nov 24, 2025 •
edited
Loading

Changes Made

  • Create 3 layers: data, domain, presentation. Biggest Migration | Refactoring Entire Codebase #42
  • Dependency Injection: injected database and other high build (heavy) cost dependency using koin.
  • Improve Code Quality: remove old code, separated code into different layers & use-cases. improve code using lint
  • Performance Update: reduce unwanted dependencies, and make code style better...
  • Improve version catalog & build script: centralized all version definitions.

Breaking Changes

  • Replace shared preference with datastore, this changes might break the previously stored app settings & feature flag settings....

Notes

  • Better Separation of Build Variant: The Main Screen (Activity) UI change in response to the app build variant you are using, make it less confusing. for developer which variant they are using.. it also add build info for developers....

@JeelDobariya38 JeelDobariya38 self-assigned this Nov 24, 2025
@JeelDobariya38 JeelDobariya38 added refactor refactor the code highlights highly impactful changes labels Nov 24, 2025
@JeelDobariya38 JeelDobariya38 changed the title Migrate: Clean Architecture Migration: Clean Architecture Nov 24, 2025
@JeelDobariya38 JeelDobariya38 marked this pull request as draft November 24, 2025 08:09
@JeelDobariya38
refactor: create PasswordRepository
1af5c84
@JeelDobariya38
refactor: use the password repository in controller
0bdf7ee
@JeelDobariya38
refactor: getpasswordbyid() in controller
d4c535a
@JeelDobariya38
refactor: updatepasswordfunction() in controller
d6502fd
@JeelDobariya38
refactor: deletepassword() in controller
25694e6
@JeelDobariya38
refactor: getallpassword() in controller
5e5a952
@JeelDobariya38
refactor: remove unwanted code from controller
1b4e7f4
@JeelDobariya38
refactor: clearalldata() in controller
30fc548
@JeelDobariya38
refactor: import password logic into a usecase
31e7366
@JeelDobariya38
refactor: use import password usecase
50c867c
@JeelDobariya38
refactor: made a export password usecase
a3be483
@JeelDobariya38
refactor: improve the usecases
310f028
@JeelDobariya38
feat: ignore the invalid entity in csv
e5a1e2c
@JeelDobariya38
refactor: remove controller class as not need anymore
ea87c75
@JeelDobariya38
refactor: the password repository a bitgit add .
04e3b04
@JeelDobariya38
refactor: comment permission class as not need currently
03a75ab
@JeelDobariya38
refactor: collecting state in xml code
f9ddfd4
@JeelDobariya38
refactor: improve csv file exporting
727caee
@JeelDobariya38
refactor: made a password modal
6bb2069
@JeelDobariya38 JeelDobariya38 merged commit fef93e2 into main Dec 15, 2025
1 check passed
@JeelDobariya38 JeelDobariya38 mentioned this pull request Dec 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kudanilll kudanilll kudanilll approved these changes

@hexCode63 hexCode63 Awaiting requested review from hexCode63

Assignees

@kudanilll kudanilll

@JeelDobariya38 JeelDobariya38

Labels

highlights highly impactful changes refactor refactor the code

Projects

None yet

Milestone

Migrate To Jetpack Compose

Development

Successfully merging this pull request may close these issues.

4 participants

@JeelDobariya38 @kudanilll @hexCode63