-
Notifications
You must be signed in to change notification settings - Fork 1
Feat: Designing New Jetpack Compose (Preview UI) #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| @Composable | ||
| fun SettingsScreen() { | ||
| val scope = rememberCoroutineScope() | ||
| val flagDataStore = LocalContext.current.featureFlagsDatastore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kudanilll Is this the correct (industry standard) apporach to use datastore?
I am not sure what is the correct way.. is it a correct way..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am specific not sure whether this is correct way or not..
I fearing any memory leaks.. or is it fine?
@yogeshpaliyal, can please help with this question or should i use application context...
Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20250517 to 20251224. - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md) - [Commits](https://github.com/douglascrockford/JSON-java/commits) --- updated-dependencies: - dependency-name: org.json:json dependency-version: '20251224' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps androidx.compose:compose-bom from 2025.12.00 to 2025.12.01. --- updated-dependencies: - dependency-name: androidx.compose:compose-bom dependency-version: 2025.12.01 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [com.google.devtools.ksp](https://github.com/google/ksp) from 2.3.3 to 2.3.4. - [Release notes](https://github.com/google/ksp/releases) - [Commits](google/ksp@2.3.3...2.3.4) --- updated-dependencies: - dependency-name: com.google.devtools.ksp dependency-version: 2.3.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps `kotlin` from 2.2.21 to 2.3.0. Updates `org.jetbrains.kotlin.android` from 2.2.21 to 2.3.0 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.2.21...v2.3.0) Updates `org.jetbrains.kotlin.plugin.compose` from 2.2.21 to 2.3.0 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.2.21...v2.3.0) Updates `org.jetbrains.kotlin.plugin.serialization` from 2.2.21 to 2.3.0 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.2.21...v2.3.0) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin.android dependency-version: 2.3.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.jetbrains.kotlin.plugin.compose dependency-version: 2.3.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.jetbrains.kotlin.plugin.serialization dependency-version: 2.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps androidx.activity:activity-compose from 1.12.1 to 1.12.2. --- updated-dependencies: - dependency-name: androidx.activity:activity-compose dependency-version: 1.12.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps androidx.compose:compose-bom from 2025.12.01 to 2026.01.00. --- updated-dependencies: - dependency-name: androidx.compose:compose-bom dependency-version: 2026.01.00 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.jetbrains.kotlinx:kotlinx-serialization-json](https://github.com/Kotlin/kotlinx.serialization) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/Kotlin/kotlinx.serialization/releases) - [Changelog](https://github.com/Kotlin/kotlinx.serialization/blob/master/CHANGELOG.md) - [Commits](Kotlin/kotlinx.serialization@v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: org.jetbrains.kotlinx:kotlinx-serialization-json dependency-version: 1.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps `agp` from 8.13.2 to 9.0.0. Updates `com.android.application` from 8.13.2 to 9.0.0 Updates `com.android.library` from 8.13.2 to 9.0.0 --- updated-dependencies: - dependency-name: com.android.application dependency-version: 9.0.0 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: com.android.library dependency-version: 9.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps gradle-wrapper from 9.2.0 to 9.3.0. --- updated-dependencies: - dependency-name: gradle-wrapper dependency-version: 9.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
d07aeeb to
1cbb5ad
Compare
|
I mess up the commit history again... i just rebase main to this branch but i forget rebase shouldn't be use with remotely shared branch..... 😂 i will fix history tommorow for better or worse... (by force push the local copy of jeel-dev branch) it will make it worse for this pr (and reviewers) because it will expand the commit but for repository it will be good... |
Changes Made
Notes
It note the final UI, just something that works (bare mimimal) we will work on improving the UI later..