-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/pna 1438 navpill jump #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a page jumping issue that occurred when switching between tabs in the Quarto-rendered HTML report. The fix involves CSS changes to control scroll behavior and a JavaScript solution to lock tab content height during transitions.
Key Changes:
- Added CSS rules to prevent scroll-based jumping in tab containers
- Implemented JavaScript to lock/unlock tab content height during tab transitions
- Adjusted heading hierarchy in spatial and abundance sections to match the new tab structure
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| inst/quarto/styles.css | Added CSS to disable scroll behavior and overflow anchoring in tab content |
| inst/quarto/custom.html | New JavaScript file that locks tab content height during transitions to prevent jumping |
| inst/quarto/pixelatorES.qmd | Added reference to include the custom.html file |
| inst/quarto/spatial.qmd | Updated heading levels from ### to #### and ##### to maintain proper hierarchy with new structure |
| inst/quarto/abundance.qmd | Updated heading levels from ### to #### to maintain proper hierarchy with new structure |
| CHANGELOG.md | Updated version number and documented the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Just tested, can confirm the jumping is gone. Well done! |
Description
draw_quantilesin favor ofggplot2functionality doing the same thing but less error prone.Fixes: PNA-1438
Type of change
How Has This Been Tested?
Manual testing.
PR checklist: