Skip to content

Conversation

@maxkarlsson
Copy link
Collaborator

@maxkarlsson maxkarlsson commented Nov 28, 2025

Description

  • Fixed an issue where the screen would "jump" to the top of the page when changing tabs.
  • Removed draw_quantiles in favor of ggplot2 functionality doing the same thing but less error prone.

Fixes: PNA-1438

Type of change

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Manual testing.

PR checklist:

  • I have run R CMD check on the package and it passes.
  • I have made changes to the documentation.
  • I have added tests.
  • I have documented any significant changes in CHANGELOG.md

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a page jumping issue that occurred when switching between tabs in the Quarto-rendered HTML report. The fix involves CSS changes to control scroll behavior and a JavaScript solution to lock tab content height during transitions.

Key Changes:

  • Added CSS rules to prevent scroll-based jumping in tab containers
  • Implemented JavaScript to lock/unlock tab content height during tab transitions
  • Adjusted heading hierarchy in spatial and abundance sections to match the new tab structure

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
inst/quarto/styles.css Added CSS to disable scroll behavior and overflow anchoring in tab content
inst/quarto/custom.html New JavaScript file that locks tab content height during transitions to prevent jumping
inst/quarto/pixelatorES.qmd Added reference to include the custom.html file
inst/quarto/spatial.qmd Updated heading levels from ### to #### and ##### to maintain proper hierarchy with new structure
inst/quarto/abundance.qmd Updated heading levels from ### to #### to maintain proper hierarchy with new structure
CHANGELOG.md Updated version number and documented the bug fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@maxkarlsson maxkarlsson marked this pull request as ready for review November 28, 2025 08:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stefanppetkov
Copy link

Just tested, can confirm the jumping is gone. Well done!

@maxkarlsson maxkarlsson merged commit 7795980 into main Dec 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants